Skip to content

Confirm compatibility with WordPress 6.6 #468

Closed

Description

@joelabreo227

Summary

Confirm compatibility with WordPress 6.6.

Team

Primary Assignee: @mchirag2002
PR reviewer: @SH4LIN
QA: @maharrshi

References

Acceptance Criteria

  • As a WordPress engineer, I can use Elementary to scaffold a brand new project with WordPress 6.6
  • New features work as expected
  • Deprecations are gracefully handled
## Additional Tasks
- [ ] Create testing methodology documentation for WP upgrade testing (which can be used going forward) @mchirag2002
- [ ] Support for Interactivity API @SH4LIN
- [ ] Run PHPCS scan @mchirag2002
- [ ] Make sure that README is up to date @mchirag2002
  - [ ] @SH4LIN Add documentation re: how to approach developing a new block
- [ ] Confirm maximum PHP compatibility @SH4LIN
- [ ] Raise PR to address issues encountered https://github.com/rtCamp/theme-elementary/issues/468#issuecomment-2235807396 @mchirag2002
- [ ] Raise PR(s) to address issues encountered https://github.com/rtCamp/theme-elementary/issues/468#issuecomment-2235807396 @mchirag2002

Activity

  1. mchirag2002 commented on Jul 18, 2024

    @mchirag2002
    Contributor

    Things Tested:

    • Theme installation functionality
    • Development commands like npm commands.

    Issues encountered and fixes for them:

    • Found a deprecated node parser

      image

      Fix: Update the node module.

    • Found several PHPCS issues in multiple files related to 'Short array syntax usage'

      image

      Also found the following issues when WordPress-VIP-Go standard was used to check

      image

      Fix: Update the syntax and fix all the phpcs issues with WordPress standard and raise a PR to main.

    New features that can be used in the project:

    cc: @joelabreo227

  2. mchirag2002 commented on Jul 18, 2024

    @mchirag2002
    Contributor

    New features that can be used in the project: (Contd.)

    • We can also leverage the Section Styles feature integrated with the default font size and typography feature in theme.json to provide the end user a lot of preset styles for their new custom themes.
  3. RahiDroid commented on Jul 18, 2024

    @RahiDroid
    Member

    @mchirag2002 The flagged issue look fine to be fixed. For below,

    Found several PHPCS issues in multiple files related to 'Short array syntax usage'

    We at rtCamp prefer to use short-array syntax. So please update the phpcs.xml file to ignore that sniff.

  4. maharrshi commented on Jul 19, 2024

    @maharrshi

    Installation Setup:

    Method 1: Does not work
    Steps Followed:
    1: setup local site
    2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name]
    3: while going through the themes set up following error occurs:
    image
    The log file for the same :
    2024-07-19T09_49_42_659Z-debug-0.log

    Method 2: Works fine
    cc: @mchirag2002

  5. maharrshi commented on Jul 19, 2024

    @maharrshi

    Theme check produces errors
    image

  6. SH4LIN commented on Jul 19, 2024

    @SH4LIN
    Contributor

    Installation Setup:

    Method 1: Does not work Steps Followed: 1: setup local site 2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name] 3: while going through the themes set up following error occurs: image The log file for the same : 2024-07-19T09_49_42_659Z-debug-0.log

    Method 2: Works fine cc: @mchirag2002

    I think this is happening because the theme elementary inside our composer package is not updated. What you are facing is an issue that was fixed a long time ago. I'll create task to update the composer theme

  7. SH4LIN commented on Jul 21, 2024

    @SH4LIN
    Contributor

    Confirm maximum PHP compatibility.

    Tested the theme in PHP version 8.3 and everything works perfectly.

  8. maharrshi commented on Jul 22, 2024

    @maharrshi

    image
    image
    Found these css errors while checking for the site on https://validator.w3.org/
    cc: @mchirag2002 @SH4LIN

  9. maharrshi commented on Jul 22, 2024

    @maharrshi

    QA Completed
    Site Tested: Local Site
    QA Checklist Performed:

    • Installation using two methods as per readme
    • Theme check - unit testing for the theme
    • Error logs and console errors checks
    • CSS Validation
    • Performance check
    • Cross Browser Tested(Chrome, Safari, Edge)
    • Responsive Testing
      cc: @joelabreo227
  10. divyarajmasani commented on Jan 10, 2025

    @divyarajmasani
    Contributor

    Marking this as complete, as per the last comment the QA has been performed.

    And would prefer to open a new issue for the v6.7 or any enhancements.

    Cc: @joelabreo227 @mchirag2002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions