Skip to content

Replace buttons with ToolbarItem buttons in sheets - #138

Merged
rsyncOSX merged 1 commit into
rsyncOSX:version-3.0.3-trfrom
timreichen:sheet-toolbar-buttons-2
Jul 8, 2026
Merged

rsyncOSX merged 1 commit into
rsyncOSX:version-3.0.3-trfrom
timreichen:sheet-toolbar-buttons-2

Conversation

@timreichen

Copy link
Copy Markdown
Contributor

This PR replaces add/cancel buttons in AddTaskView and ProfileView with ToolbarItems containing buttons.
They also have https://developer.apple.com/documentation/swiftui/toolbaritemplacement/confirmationaction and https://developer.apple.com/documentation/swiftui/toolbaritemplacement/cancellationaction for sensible default behaviours.
617492708-6ea9951c-c5e5-4806-be7b-4e644f9387b9
617492759-ec9b3733-be14-44ba-a616-d712ca7becff

@rsyncOSX

rsyncOSX commented Jul 7, 2026

Copy link
Copy Markdown
Owner

I am on travel for some days now, will commit later this week.

@rsyncOSX
rsyncOSX changed the base branch from main to version-3.0.3-tr July 8, 2026 04:31
@rsyncOSX
rsyncOSX merged commit a81da0d into rsyncOSX:version-3.0.3-tr Jul 8, 2026
@rsyncOSX

rsyncOSX commented Jul 8, 2026

Copy link
Copy Markdown
Owner

I have pulled all five pr into ver3.0.3-tr, will test all of them in some days.. Still on travel :-)

@timreichen
timreichen deleted the sheet-toolbar-buttons-2 branch July 8, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants