Skip to content

Add plumb_api() and available_apis() - #631

Merged
schloerke merged 21 commits into
masterfrom
available_plumbers
Aug 6, 2020
Merged

schloerke merged 21 commits into
masterfrom
available_plumbers

Conversation

@schloerke

@schloerke schloerke commented Aug 5, 2020 •

Copy link
Copy Markdown
Collaborator

PR task list:

  • Update NEWS
  • Add tests
  • Update documentation with devtools::document()
  • Separate documentation for plumber() and plumb()
  • Update Docker file to accept file location
  • Remove TODO on inferring the content type in include_file()

@schloerke
schloerke marked this pull request as ready for review August 5, 2020 15:44
@schloerke
schloerke requested a review from cpsievert August 5, 2020 15:44
Comment thread NEWS.md Outdated
Comment thread R/includes.R Outdated
Comment thread R/plumb.R Outdated
Comment thread R/plumb.R Outdated
Comment thread R/plumb.R Outdated
Comment thread R/plumb.R Outdated
Comment thread R/plumb.R
Comment thread NEWS.md Outdated
Comment thread tests/testthat/test-openapi.R Outdated
@cpsievert
cpsievert self-requested a review August 5, 2020 19:01

@cpsievert cpsievert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending suggestions

@schloerke
schloerke merged commit 58e84ac into master Aug 6, 2020
@schloerke
schloerke deleted the available_plumbers branch August 6, 2020 17:21
schloerke added a commit that referenced this pull request Aug 7, 2020
* master:
  Add `plumb_api()` and `available_apis()` (#631)
  Allow serializers to return hooks and a serializer function. Port all image serializers to use new functionality (#630)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants