Skip to content

Ensure data-bs-toggle is present in the BS3 tabset compatibility shims #492

Open

Description

@gadenbuie

As we noticed in rstudio/flexdashboard#421, newer version of Bootstrap may require the data-bs-toggle in places where data-toggle was previously sufficient. In theory, we could handle this in the tabset compatibility shims by ensuring that data-toggle is copied to data-bs-toggle if the latter isn't present.

var SELECTOR = '[data-toggle="tab"], [data-toggle="pill"], [data-bs-toggle="tab"], [data-bs-toggle="pill"]';
$(document).on(EVENT_KEY, SELECTOR, function(event) {
event.preventDefault();
$(this).tab("show");
});

Activity

  1. self-assigned this
    on Mar 10, 2023
  2. added 2 commits that reference this issue on Mar 10, 2023
    54ef365
    5153b4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions