Codecs for Per-Stream MimeType Extension#998
Closed
rudy2steiner wants to merge 4 commits intorsocket:masterfrom
Closed
Codecs for Per-Stream MimeType Extension#998rudy2steiner wants to merge 4 commits intorsocket:masterfrom
rudy2steiner wants to merge 4 commits intorsocket:masterfrom
Conversation
Signed-off-by: rudy2steiner <rudy_steiner@163.com>
Signed-off-by: rudy2steiner <rudy_steiner@163.com>
rudy2steiner
force-pushed
the
stream_mime
branch
from
450afeb to
72ff46f
Compare
rstoyanchev
requested changes
Mar 18, 2021
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
Thanks for the pull request. See feedback below.
rsocket-core/src/test/java/io/rsocket/metadata/MimeMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/test/java/io/rsocket/metadata/MimeMetadataCodecTest.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/metadata/MimeMetadataCodec.java
Outdated
Show resolved
Hide resolved
Signed-off-by: rudy2steiner <rudy_steiner@163.com>
Contributor
Author
|
@rstoyanchev thanks for you valuable feedbacks, all request changes have done. |
Signed-off-by: rudy2steiner <rudy_steiner@163.com>
rudy2steiner
force-pushed
the
stream_mime
branch
from
9ba46c4 to
682e355
Compare
Contributor
|
Thanks for the updates, this is now in master. |
Contributor
Author
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A codec for stream data MIME types metadata and spring-projects/spring-framework#26379 depend on this implementation
Fix issue #996
Motivation:
There is currently no encoding and decoding support for the PerStreamDataMimeTypesDefinition extension