Merged
Conversation
OlegDokuka
force-pushed
the
enhancement/request-intereptor-feature
branch
from
eeaac34 to
0b108ea
Compare
rstoyanchev
requested changes
Oct 13, 2020
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
Looks good overall, some comments below.
rsocket-core/src/main/java/io/rsocket/plugins/InitializingInterceptorRegistry.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/plugins/InterceptorRegistry.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/core/FireAndForgetRequesterMono.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/plugins/RequestInterceptor.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/plugins/SafeCompositeRequestInterceptor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/request-intereptor-feature
branch
from
0b108ea to
cc4595b
Compare
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/request-intereptor-feature
branch
from
cc4595b to
168450e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a
RequestInterceptorinterface API and an appropriate implementation in every RequestOperator implementation.This interceptor is a building block to build Stats/Metrics tracking without providing a wrapper for every call.
Signed-off-by: Oleh Dokuka shadowgun@i.ua