ensures that resumability implementation is stable#934
Merged
OlegDokuka merged 3 commits intomasterfrom Sep 30, 2020
Merged
Conversation
OlegDokuka
changed the title
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/resumability-next-session
branch
from
8236fd3 to
c8a0d99
Compare
rstoyanchev
requested changes
Sep 29, 2020
rsocket-core/src/main/java/io/rsocket/resume/ResumableDuplexConnection.java
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/resume/ClientRSocketSession.java
Outdated
Show resolved
Hide resolved
rsocket-core/src/main/java/io/rsocket/resume/InMemoryResumableFramesStore.java
Outdated
Show resolved
Hide resolved
rsocket-test/src/main/java/io/rsocket/test/LeaksTrackingByteBufAllocator.java
Show resolved
Hide resolved
Co-authored-by: Rossen Stoyanchev <rstoyanchev@users.noreply.github.com> Signed-off-by: Oleh Dokuka <shadowgun@i.ua>
OlegDokuka
force-pushed
the
enhancement/resumability-next-session
branch
from
4629e09 to
0d2a725
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that resumability implementation is stable and does not have any mem leaks in it