introduces onClose listener for RSocketClient and connect method#1063
Merged
OlegDokuka merged 2 commits into1.1.xfrom Sep 14, 2022
Merged
introduces onClose listener for RSocketClient and connect method#1063OlegDokuka merged 2 commits into1.1.xfrom
onClose listener for RSocketClient and connect method#1063OlegDokuka merged 2 commits into1.1.xfrom
Conversation
OlegDokuka
changed the title
connect method
OlegDokuka
changed the title
connect methodonClose listener for RSocketClient and connect method
rstoyanchev
reviewed
Sep 7, 2022
Contributor
rstoyanchev
left a comment
rstoyanchev
left a comment
There was a problem hiding this comment.
Looks good. Only a couple of small comments for the connect method, which could also be split out into a separate commit as it is orthogonal to the onClose I think.
|
|
||
| default boolean connect() { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
I think this should raise NotImplementedException or not have a default implementation at all.
Contributor
There was a problem hiding this comment.
It also needs Javadoc to state what it does, when this is useful vs just making requests, when it returns true vs false, and what happens for any scenarios of interest (e.g. if already connected, if already terminated, etc).
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
OlegDokuka
force-pushed
the
enhancement/1.1.x-client-start-onclose
branch
from
14fbd84 to
40e02a5
Compare
Member
Author
|
@rstoyanchev added 2 separate commits as it was suggested |
rstoyanchev
reviewed
Sep 9, 2022
rsocket-core/src/main/java/io/rsocket/core/RSocketClientAdapter.java
Outdated
Show resolved
Hide resolved
OlegDokuka
force-pushed
the
enhancement/1.1.x-client-start-onclose
branch
2 times, most recently
from
b7b3c4a to
d1875da
Compare
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> Co-authored-by: Rossen Stoyanchev <rstoyanchev@users.noreply.github.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com>
OlegDokuka
force-pushed
the
enhancement/1.1.x-client-start-onclose
branch
from
d1875da to
7502fde
Compare
rstoyanchev
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1048
Signed-off-by: Oleh Dokuka odokuka@vmware.com
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com