improves BaseDuplexConnection and fixes PingClient impl#1062
Merged
OlegDokuka merged 1 commit into1.1.xfrom Aug 20, 2022
Merged
improves BaseDuplexConnection and fixes PingClient impl#1062OlegDokuka merged 1 commit into1.1.xfrom
OlegDokuka merged 1 commit into1.1.xfrom
Conversation
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> Signed-off-by: OlegDokuka <odokuka@vmware.com>
OlegDokuka
pushed a commit
that referenced
this pull request
Aug 20, 2022
Signed-off-by: Oleh Dokuka <odokuka@vmware.com> Signed-off-by: Oleh Dokuka <oleh.dokuka@icloud.com> Signed-off-by: OlegDokuka <odokuka@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleh Dokuka odokuka@vmware.com
Signed-off-by: Oleh Dokuka oleh.dokuka@icloud.com
Improves
BaseDuplexConnectionimplMotivation:
the impl of BaseDuplexConnection is a bit awkward because of the previous iterative reimplementation of that class.
Modifications:
This PR makes all protected fields as final (initial goal) and rework onClose notification mechanism