First pass on Micrometer Observation API#1036
Closed
marcingrzejszczak wants to merge 10 commits intorsocket:masterfrom
Closed
First pass on Micrometer Observation API#1036marcingrzejszczak wants to merge 10 commits intorsocket:masterfrom
marcingrzejszczak wants to merge 10 commits intorsocket:masterfrom
Conversation
jonatan-ivanov
approved these changes
Feb 10, 2022
jonatan-ivanov
left a comment
jonatan-ivanov
left a comment
There was a problem hiding this comment.
I'm not an rsocket expert but it looks good.
gradle.properties
Outdated
| # limitations under the License. | ||
| # | ||
| version=1.1.2 | ||
| version=2.0.0-SNAPSHOT |
There was a problem hiding this comment.
Isn't this the version of rsocket-java? :)
Contributor
Author
There was a problem hiding this comment.
Yeah I thought that this might be released as RSocket 2.0.0 cause we're introducing micrometer that introduces breaking changes. We'll see if it actually remains 2.0.0 or 1.2
marcingrzejszczak
force-pushed
the
observation
branch
from
ff1dea3 to
216783d
Compare
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
marcingrzejszczak
force-pushed
the
observation
branch
from
64e691c to
c83a2cb
Compare
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
Signed-off-by: Marcin Grzejszczak <mgrzejszczak@vmware.com>
marcingrzejszczak
force-pushed
the
observation
branch
from
cd010e6 to
2d54c9e
Compare
Member
|
superseded by #1056 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./gradlew generateObservabilityDocswe will generate metrics and span docs inroot/buildfolder