tell the user to restart game if package.json is changed#32
Merged
rphsoftware merged 1 commit intorphsoftware:masterfrom Aug 4, 2024
Merged
tell the user to restart game if package.json is changed#32rphsoftware merged 1 commit intorphsoftware:masterfrom
rphsoftware merged 1 commit intorphsoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing the package.json file can change the Chromium launch arguments.
nwjs doesn't support restarting the Chromium instance without full process restart and
NodeJS doesn't support something like execve(), hence there is no
(chrome.runtime.reload() is closer to reloading a tab than restarting the whole browser)
Spawning and detaching a child process will cause Steam to stop tracking play time.
Just tell the user to restart the game to avoid surprises why the changes don't apply.