This repository was archived by the owner on Dec 27, 2018. It is now read-only.
Add tox test and vagrant confluence instance#17
Open
ytjohn wants to merge 2 commits intorpcope1:masterfrom
Open
Add tox test and vagrant confluence instance#17ytjohn wants to merge 2 commits intorpcope1:masterfrom
ytjohn wants to merge 2 commits intorpcope1:masterfrom
Conversation
Owner
|
Very cool! I am going to look through these commits soon...I think I can certainly help write some tests as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the following:
I wrote a handful of tests. It's only covers a portion of the API calls, but should provide a basis for adding more tests. Tests are executed in the order they appear within the file.
I did not add a
make release/make buildcommand to the Makefile as I wasn't sure of your build process for pip (and I wouldn't really be able to evaluate it either). You may consider looking at how flask does their make-release script, which is called bymake release.