Repository navigation
Add Find in store and Check for updates to installed plugins - #458
Open
GoblinRules wants to merge 10 commits into
Open
GoblinRules wants to merge 10 commits into
GoblinRules wants to merge 10 commits into
Conversation
This was referenced Oct 15, 2026
Contributor
|
This pull request targeted The base branch has been automatically changed to |
lzt404
force-pushed
the
dev
branch
2 times, most recently
from
October 19, 2026 05:15
1c13fe0 to
3ee2314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed plugin cards currently offer no direct route back to their store listing. Add Find in store to every local card and Check for updates to installed cards.
Both actions open the store filtered by plugin ID. Checking fetches the store API and refreshes public GitHub release versions using upstream’s existing release-refresh API and reports available, current, missing, incomplete, or unverified results. Only a unique matching installation source and known matching versions can produce an up-to-date result; failed sources and ambiguous/manual installs remain explicit. Installation still uses the existing source-aware confirmation flow and never starts automatically. Refresh/retry repeats an active check.
Includes English, Simplified/Traditional Chinese and Japanese strings, provenance/error unit coverage, and browser coverage for installed-card navigation and checking without installation. Includes sidebar PR #457 as its prerequisite in the tested series.
Validation:
bun run checkpasses; 49 focused Bun tests pass on the final combined series; the plugin browser workflow passes, including installed-card navigation and checking without installation. Full production build passes on the combined series. Browser checks use the IPC mock; the latest native-viewer adaptation has not been tested in a packaged desktop build. The prerequisite fixes the existing timer type errors.Merge order and review scope
This is part 2 of the tested series: #457 → #458 → #459 → #460. Later branches include their predecessors, with overlapping code already resolved. All four now target upstream
dev, as selected upstream. The tested main merge8e013baincludes dev tip44ab185. Merge in that order using merge commits to preserve ancestry; if squash/rebase is preferred, the remaining branches need rebasing before merging.Review this layer against its predecessor: incremental diff. Until predecessors land, GitHub's base-branch Files changed view includes those prerequisite changes. The lab packaging and build configuration remain fork-only and are not included in these PRs.