Repository navigation
Conversation
lzt404
added a commit
that referenced
this pull request
Oct 12, 2026
Roomen
force-pushed
the
feat/oauth-multi-account-ux
branch
from
October 12, 2026 05:51
b42b8ab to
d2063de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuth sign-in already supports adding any number of accounts per provider, and every successful sign-in is saved as a new credential file. The login page did not show this: every card always offered "Start Sign-In" and only showed a session-scoped "Completed" pill, so users often assumed earlier sign-ins had failed or been lost.
groupOAuthAccountsByProviderinservices/authFiles.ts, reusing the existing dedupe and OAuth-file filters, so runtime-only and API key entries are excluded.Screenshots
Captured with the browser mock (
?mock=running).Validation
bun run checkbun test tests/authFiles.test.ts tests/oauthLoginState.test.ts, including a new test for the account grouping helpertests/meta-oauth-ui.cjspasses once the stale card count is corrected (see note below)tests/devin-ui.cjspasses all OAuth login steps; it then stops at the existingdevin-test.jsonstrict-mode assertion in the Authentication Files view, which fails the same way on currentdevNote: on current
dev,meta-oauth-ui.cjs,devin-ui.cjsandplugin-oauth-providers-ui.cjsalready fail their.oauth-cardcount assertions because of the Vertex card. This PR leaves those assertions alone, since #384 addresses them; it only updates the button and status labels these tests look for.