docs: define context workspaces and access modes - #2396
Merged
cwiklik merged 4 commits intoAug 19, 2026
Conversation
Signed-off-by: Jeremy Cohn <jacohn1@gmail.com>
Signed-off-by: Jeremy Cohn <jacohn1@gmail.com>
cwiklik
approved these changes
Aug 18, 2026
cwiklik
left a comment
Contributor
There was a problem hiding this comment.
Summary
Docs-only expansion of docs/concepts/context-service.md — defines workspaces in filesystem terms, explains the PVC implementation, and maps CLI default/--shared to ReadWriteOnce/ReadWriteMany.
I checked the storage semantics and they're accurate:
- RWO framed as "writable from Pods on one cluster node at a time," explicitly not one-Pod exclusivity and not a security boundary — correct (that's the RWO/node-scoped vs ReadWriteOncePod distinction, and multiple pods on the same node can indeed share an RWO volume).
- RWX correctly noted as requiring a CSI driver that supports it.
- The PVC-protection finalizer keeping a volume in
Terminatingwhile a Pod still mounts it is accurate, and nicely framed as "a safety net, not a substitute for user-facing dependency checks."
Also appreciate the honesty about what isn't built yet (usage reporting, safe-deletion prompts) with a follow-up issue link, rather than implying it works. CI is green (Markdown Lint + Link Check included), DCO signed, no .claude//.vscode/ changes.
Approving.
Author: moonlight16 (MEMBER — maintainer)
Areas reviewed: Docs, storage-semantics accuracy (RWO/RWX/PVC protection)
CI: all green.
cwiklik
enabled auto-merge
August 19, 2026 17:47
cwiklik
disabled auto-merge
August 19, 2026 18:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand the canonical Context Service concept documentation in response to CLI
review feedback.
familiarity
--sharedyet, including the limited protection Kubernetes provides for mounted PVCs
This is the primary conceptual documentation referenced by
rossoctl/rossoctl-cli#73.
Validation
git diff --check