Skip to content

Use target_link_libraries instead of ament_target_dependencies#507

Merged
ct2034 merged 1 commit into
ros:ros2from
christophfroehlich:fix/ament
May 26, 2025
Merged

Use target_link_libraries instead of ament_target_dependencies#507
ct2034 merged 1 commit into
ros:ros2from
christophfroehlich:fix/ament

Conversation

@christophfroehlich

Copy link
Copy Markdown
Contributor

the ros2 branch does not compile on rolling-testing because
ament/ament_cmake#583
got merged, before
ament/ament_cmake#572
got synced.

Fixes ros-controls/ros2_control#2272

@mergify mergify Bot added the ros2 PR tackling a ROS2 branch label May 24, 2025

@bmagyar bmagyar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding!

@destogl

destogl commented May 26, 2025

Copy link
Copy Markdown

Very nice!

@ct2034

ct2034 commented May 26, 2025

Copy link
Copy Markdown
Collaborator

Thanks @christophfroehlich :)

@ct2034
ct2034 merged commit f516165 into ros:ros2 May 26, 2025
ct2034 pushed a commit to ct2034/diagnostics that referenced this pull request May 26, 2025
@ct2034

ct2034 commented May 26, 2025

Copy link
Copy Markdown
Collaborator

💚 All backports created successfully

Status Branch Result
ros2-kilted

Questions ?

Please refer to the Backport tool documentation

mergify Bot added a commit that referenced this pull request May 26, 2025
[ros2-kilted] Use target_link_libraries instead of ament_target_dependencies (#507)
ct2034 pushed a commit that referenced this pull request Mar 30, 2026
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ros2 PR tackling a ROS2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI build job rolling/source failed!

5 participants