Changes the use of __slots__ for the field and field type getter#289
Merged
clalancette merged 2 commits intoros-visualization:rollingfrom Apr 3, 2023
Merged
Conversation
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
clalancette
requested changes
Apr 3, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
One change inline, otherwise this looks good to me.
Signed-off-by: Voldivh <eloyabmfcv@gmail.com>
clalancette
approved these changes
Apr 3, 2023
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Contributor
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the use of
__slots__for the appropriate message components name getter. This changes should solve the problems when this PR is incorporated.