Conversation
asdolo
requested review from
fernandatoledo,
guillermomachado,
juanchoperezj and
marcos09
💯 Test Coverage
😎 Tests Results
👀 Tests Details • (51%)
|
guillermomachado
approved these changes
Sep 10, 2024
asdolo
force-pushed
the
refactor/cli_move_file_operations_to_project_files_manager_class
branch
from
ae8d07c to
0a34d29
Compare
asdolo
force-pushed
the
refactor/cli_move_file_operations_to_project_files_manager_class
branch
from
0a34d29 to
29594e4
Compare
fernandatoledo
approved these changes
Sep 10, 2024
asdolo
deleted the
refactor/cli_move_file_operations_to_project_files_manager_class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Create a
ProjectFilesManagerclass to manage common file operations (removing, renaming and replacing files). It includes types annotations.Why did you do this?
Who/what does this impact?
Developers of the CLI project.
How did you test this?
I created a new application with the current version of the CLI, without these changes. Then I created another application with this new CLI, and I compared both projects. As this is just a refactor and no new functionality is being implemented, the two projects should and did have the same contents.