Skip to content

feat(cli): use our repository as template#21

Merged
asdolo merged 1 commit into
masterfrom
feat/cli_use_our_repository_as_template
Aug 5, 2024
Merged

feat(cli): use our repository as template#21
asdolo merged 1 commit into
masterfrom
feat/cli_use_our_repository_as_template

Conversation

@asdolo
Copy link
Copy Markdown
Collaborator

@asdolo asdolo commented Aug 2, 2024

What does this do?

  • Use our repository as template when executing the CLI.
  • Change some wordings like "Starter" to "Template", and change references from Obytes to Rootstrap.
  • Refactor some code to reuse strings, or read them from the package.json file.
  • TODO: The README file from the CLI project still needs to be changed.

Why did you do this?

  • To start testing new changes from our template into new projects started from our CLI.

Who/what does this impact?

N/A

How did you test this?

Running locally:

cd cli
./index.js MyTestApp

Then checking that the created project is consistent with what the CLI do.

@asdolo asdolo self-assigned this Aug 2, 2024
@asdolo asdolo requested a review from a team as a code owner August 2, 2024 23:33
@fernandatoledo
Copy link
Copy Markdown
Collaborator

I'd opened this PR: #16 that adds an script to be able to setup de project locally without publishing the module to NPM, maybe it's no longer necessary, but in that case maybe there are pieces we can get from both of them.

Base automatically changed from chore/rename_cli_to_create_rootstrap_rn_app to master August 5, 2024 16:14
@asdolo asdolo force-pushed the feat/cli_use_our_repository_as_template branch from ff09887 to a58b597 Compare August 5, 2024 16:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 5, 2024

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 42%
41.33% (210/508) 36.72% (83/226) 27.83% (54/194)

😎 Tests Results

Tests Skipped Failures Errors Time
47 0 💤 0 ❌ 0 🔥 26.353s ⏱️
👀 Tests Details • (42%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files41.3336.7227.8342.44 
report-only-changed-files is enabled. No files were changed in this commit :)

@asdolo asdolo merged commit 303435f into master Aug 5, 2024
@asdolo asdolo deleted the feat/cli_use_our_repository_as_template branch August 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants