Update Kotlin, Hilt, and all the dependencies. Fix upgrading issues#51
Conversation
hrodrick
requested review from
amaury901130,
jjszolno,
lmiotti,
marcossalto,
mato2593 and
ximenaperez
|
Detected some compiling errors that only happen in AppCenter because of outdated libraries that I didn't see. Note : Fastlane build was successful Update
|
… api 31. Update Firebase
| apply plugin: 'kotlin-android-extensions' | ||
|
|
There was a problem hiding this comment.
why you remove this?
There was a problem hiding this comment.
I think that Kotlin extensions are deprecated and replaced with ViewBinding. @hrodrick I'm right?
There was a problem hiding this comment.
Kotlin extension are deprecated. We should use view binding and @parcelize. Good update!
There was a problem hiding this comment.
Yes, Kotlin extensions are deprecated and kotlin synthetics is replaced by View & Data binding
amaury901130
left a comment
amaury901130
left a comment
There was a problem hiding this comment.
Good, just a couple of questions.
|
|
||
| @Module | ||
| @InstallIn(ApplicationComponent::class) | ||
| @InstallIn(SingletonComponent::class) |
There was a problem hiding this comment.
could you please explain this change?
There was a problem hiding this comment.
ApplicationComponent was renamed to SingletonComponent to allow the usage of Hilt in non-Android modules. You can check this release notes for further information : https://github.com/google/dagger/releases/tag/dagger-2.28.2
|
|
||
| @Module | ||
| @InstallIn(ApplicationComponent::class) | ||
| @InstallIn(SingletonComponent::class) |
There was a problem hiding this comment.
ApplicationComponent was renamed to SingletonComponent to allow the usage of Hilt in non-Android modules. You can check this release notes for further information : https://github.com/google/dagger/releases/tag/dagger-2.28.2
| <option name="useQualifiedModuleNames" value="true" /> | ||
| </GradleProjectSettings> | ||
| </option> | ||
| </component> |
There was a problem hiding this comment.
I think this file should be ignore from git. Perhaps we need clear git cache to apply changes
There was a problem hiding this comment.
Yes you are right, I made the issue #52 to solve that problem.
5 participants
ISSUE[#50]
Description
deprecated) to android viewBinding3.29.1)kapt : correctErrorTypesas it is required by new Hilt versions to correctly inject depedencies