View models comunication#32
Merged
Merged
Conversation
amaury901130
requested review from
CamilaMoscatelli,
jjszolno,
mato2593 and
ximenaperez
amaury901130
force-pushed
the
enhacement/view_model_delegations
branch
from
23e883f to
91f3d84
Compare
amaury901130
force-pushed
the
enhacement/view_model_delegations
branch
from
91f3d84 to
a4df0a2
Compare
glm4
reviewed
Jul 15, 2020
| <!-- Profile --> | ||
| <string name="welcome_message">Hi %1$s!</string> | ||
| <string name="sign_out">Sign Out</string> | ||
| <string name="default_error">Opps!!!, Network error!!!</string> |
There was a problem hiding this comment.
typo en Oops! Also avoid extra punctuation characters and keep the translations correct as possible.
Oops! Network error. is better IMO.
amaury901130
force-pushed
the
enhacement/view_model_delegations
branch
from
2968b97 to
7661ce4
Compare
amaury901130
force-pushed
the
enhacement/view_model_delegations
branch
from
7661ce4 to
596736d
Compare
glm4
approved these changes
Jul 15, 2020
amaury901130
force-pushed
the
enhacement/view_model_delegations
branch
from
8dbbd8e to
0d74489
Compare
ximenaperez
approved these changes
Jul 16, 2020
jjszolno
approved these changes
Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View Models and views interaction.
Proposal for interaction between view models and views.