fix: wrap get_permalink() with esc_url() in excerpt_more filter#3291
Open
thisismyurl wants to merge 2 commits into
Open
fix: wrap get_permalink() with esc_url() in excerpt_more filter#3291thisismyurl wants to merge 2 commits into
thisismyurl wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the WordPress excerpt “more” link to use a properly escaped permalink URL.
Changes:
- Escape the permalink output in the
excerpt_morefilter usingesc_url().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Good catch — pushed a follow-up that removes the extra spaces to match the file's existing style: esc_url(get_permalink()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
excerpt_morefilter inapp/filters.phpplaces the result ofget_permalink()directly into anhrefattribute without passing it throughesc_url()first.get_permalink()does not sanitize or escape its output. Whileget_permalink()constructs from trusted data in most cases, WordPress coding standards require all URLs placed intohrefattributes to pass throughesc_url()— both for correctness and because a filter onpost_link(or a malformed custom permalink structure) could introduce unescaped characters thatesc_url()would catch and neutralize.This is a one-line, safe change with no functional impact on normal output.