Skip to content

feat: add PR monitor acceptance review ledger primitives - #443

Closed
ronak-guliani wants to merge 4 commits into
feat/collaborative-acceptance-corefrom
feat/pr-acceptance-evidence
Closed

ronak-guliani wants to merge 4 commits into
feat/collaborative-acceptance-corefrom
feat/pr-acceptance-evidence

Conversation

@ronak-guliani

@ronak-guliani ronak-guliani commented Sep 19, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ledger and provenance changes

  • Parent/reviewer-originated findings continue to use stable finding identity, immutable revisions, head-SHA provenance, deterministic delivery, and provider re-verification.
  • Child accepted/resolved/rejected/needs-human outcomes remain distinct; child rejection stays open as a dispute.
  • Reviewer withdrawn/revised/upheld/needs-human outcomes remain durable and auditable, including reviewer-agreed closure for a rejection.
  • buildMonitorAcceptanceProvenance binds monitor ID, canonical case/candidate IDs, optional exchange transport context, reviewed head SHA, source revision, finding/revision IDs, workflow identity/version, required coverage, diff hash, and immutable location evidence. It copies/freezes all values and never reads mutable PR/thread state.

Candidate and readiness seams

  • PullRequestMonitorReviewCandidate now uses canonical acceptance IDs/workflow types and carries review epoch, contract revision, required coverage, and previous-finding verification.
  • Candidate keys deduplicate by case/candidate/head, contract revision, workflow identity/version, and required coverage; covered evidence is not part of request identity. Eligibility exposes initial/full, head delta, contract/workflow/coverage changes, unknown applicability, duplicate, and previous-finding verification state without consulting child-turn completion.
  • Readiness remains fail-closed for incomplete pagination, failed/unknown base comparison, unknown mergeability, unresolved review threads, open/verifying/needs-human findings, and incomplete required-check evidence.
  • Required checks now require exact expected/observed identity coverage; missing, unknown, and extra identities produce the typed required-check-coverage-unknown blocker. GitHub snapshots remain unknown until a provider adapter can prove the required set.

Migration compatibility

  • Canonical Collaborative Acceptance migration is 096.
  • PR-monitor dispute migration is renumbered to 097 and remains idempotent with divergent historical-ledger repair paths.

Validation

  • pnpm fmt:check passed.
  • pnpm lint passed with existing repository warnings only.
  • pnpm typecheck passed with existing repository suggestions only.
  • pnpm test passed: 289 files passed, 2 skipped; 2,498 tests passed, 9 skipped; server serial tests also passed (102/102).
  • Focused monitor/acceptance/migration tests passed: 89/89.
  • Browser/integrated validation remains pending parent-owned validation; no competing dev server was launched.

Future coordinator seams

The later coordinator can consume canonical case/candidate/exchange IDs, transport context, immutable monitor provenance, candidate eligibility/full-vs-delta decisions, previous-finding verification, and fail-closed readiness reasons. This PR does not add the coordinator case tables/evaluator, correlated request transport, automatic queued turns, settings UI, or provider prompts.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Sep 19, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ronak-guliani
ronak-guliani changed the base branch from main to feat/collaborative-acceptance-core September 19, 2026 23:33
@github-actions github-actions Bot added size:XXL and removed size:XL labels Sep 19, 2026
@ronak-guliani

Copy link
Copy Markdown
Owner Author

Superseded by the single aggregate PR #447, which contains this PR's changes plus the complete collaborative-acceptance stack and is based directly on main.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ronak-guliani

Copy link
Copy Markdown
Owner Author

Superseded by the consolidated end-to-end implementation in #447, which targets main and contains this PR plus the acceptance domain, collaboration protocol, coordinator, and UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant