Repository navigation
feat: add PR monitor acceptance review ledger primitives - #443
Closed
ronak-guliani wants to merge 4 commits into
Closed
ronak-guliani wants to merge 4 commits into
ronak-guliani wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Sep 19, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ronak-guliani
changed the base branch from
main
to
feat/collaborative-acceptance-core
September 19, 2026 23:33
Owner
Author
|
Superseded by the single aggregate PR #447, which contains this PR's changes plus the complete collaborative-acceptance stack and is based directly on |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
Author
|
Superseded by the consolidated end-to-end implementation in #447, which targets main and contains this PR plus the acceptance domain, collaboration protocol, coordinator, and UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat/collaborative-acceptance-core.Ledger and provenance changes
accepted/resolved/rejected/needs-humanoutcomes remain distinct; child rejection stays open as a dispute.withdrawn/revised/upheld/needs-humanoutcomes remain durable and auditable, including reviewer-agreed closure for a rejection.buildMonitorAcceptanceProvenancebinds monitor ID, canonical case/candidate IDs, optional exchange transport context, reviewed head SHA, source revision, finding/revision IDs, workflow identity/version, required coverage, diff hash, and immutable location evidence. It copies/freezes all values and never reads mutable PR/thread state.Candidate and readiness seams
PullRequestMonitorReviewCandidatenow uses canonical acceptance IDs/workflow types and carries review epoch, contract revision, required coverage, and previous-finding verification.required-check-coverage-unknownblocker. GitHub snapshots remain unknown until a provider adapter can prove the required set.Migration compatibility
Validation
pnpm fmt:checkpassed.pnpm lintpassed with existing repository warnings only.pnpm typecheckpassed with existing repository suggestions only.pnpm testpassed: 289 files passed, 2 skipped; 2,498 tests passed, 9 skipped; server serial tests also passed (102/102).Future coordinator seams
The later coordinator can consume canonical case/candidate/exchange IDs, transport context, immutable monitor provenance, candidate eligibility/full-vs-delta decisions, previous-finding verification, and fail-closed readiness reasons. This PR does not add the coordinator case tables/evaluator, correlated request transport, automatic queued turns, settings UI, or provider prompts.