Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESIGN.md
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ Components are precise and restrained. Each one declares its own typography role
- **Switch:** A pill track that fills coral when checked. The thumb follows its context canvas color, 16px in the default size, 12px in small, with a 1px inset. The hit area extends 12px horizontally and 8px vertically past the track.

### Navigation
- **Sidebar:** Canvas fill with 1px region boundaries in `border-strong`. Navigation groups and the footer use the shared Separator with `border-strong`; shell columns and the Tasks card use the same token for their edges. Footer and topic-menu action glyphs follow their control's size, 14px at the small step and 16px at the medium step. Navigation rows, chat rows outside the Tasks card, and the search pill use `--row-h` (36px), with 12px corners and regular-weight `text-ui`. Both columns use the medium row inset for 12px of content padding and a matching 12px icon gap. A 16px icon slot starts at x=20 and text at x=48 within each column. Bordered links subtract their border from that inset. Project children and the Tasks card derive their text insets from the same column offset. Project chats keep the tree guide and selected marker; selection does not increase their weight. The New chat row has no separator above it, and its shortcut uses a square muted Badge rendered as `kbd`. The chat-list header aligns with the rail header. Its mode switch uses the shared outer inset and the SegmentedControl padding, independent of the row icon column. New-chat and main-chat rows share the navigation rhythm. Topic rows show a `#` in the same icon slot as the main chat so their text starts on the same vertical line. An unread count is a 16px circle with compact 11px/16px type from the host-owned `--row-count-*` tokens, expanding to a pill for wider counts. It uses `primary/15` for the fill and a 60% `primary` mix with `foreground` in OKLab for the numeral, matching the upgrade row's contrast-safe accent ink. Its border is transparent in light mode and `primary/50` in dark mode. It occupies the icon slot until the count clears and stays visible when the row menu appears. Lists and the Tasks card share an 8px outer inset, and the Tasks heading uses the same row height. The navigation rail's search trigger is a borderless pill with a `surface-muted` fill. The medium row vertical inset separates it from the navigation group. Navigation, list glyphs, and app artwork are 16px, with a 1.5px stroke for Projects. Filled artwork reads slightly larger than outline glyphs within the same fixed slots, and names stay aligned. Hover takes `surface-hover`. The selected row takes `surface`, `shadow-4`, a single 1px outer edge in `border` at 70% alpha, regular-weight text, and a `primary` glyph; dark mode uses `surface-hover`. App artwork keeps its own colors. Rows inside the Tasks card use 8px corners, matching its heading and the concentric corner rule. A selected task uses the hover fill without another shadow. Archived chats read in Subtle Ink. Unread activity is an 8px `info` dot that hides on hover to reveal the row action. Below the pinned entries, a hairline and an aux "Recent" label introduce up to three unpinned apps the guardian built or opened in the last 14 days, most recent first, with a "Show more" row for the rest. The zone is absent when empty. An installed, never-opened app carries the same 8px `info` dot, which on hover gives way to a Pin action. On touch the Pin action is always visible and the dot sits beside it.
- **Sidebar:** Canvas fill with 1px region boundaries in `border-strong`. Navigation groups and the footer use the shared Separator with `border-strong`; shell columns and the Tasks card use the same token for their edges. Footer and topic-menu action glyphs follow their control's size, 14px at the small step and 16px at the medium step. Navigation rows, chat rows outside the Tasks card, and the search pill use `--row-h` (36px), with 12px corners and regular-weight `text-ui`. Both columns use the medium row inset for 12px of content padding and a matching 12px icon gap. A 16px icon slot starts at x=20 and text at x=48 within each column. Bordered links subtract their border from that inset. Project children and the Tasks card derive their text insets from the same column offset. Project chats keep the tree guide and selected marker; selection does not increase their weight. The New chat row has no separator above it, and its shortcut uses a square muted Badge rendered as `kbd`. The chat-list header aligns with the rail header. Its mode switch uses the shared outer inset and the SegmentedControl padding, independent of the row icon column. New-chat and main-chat rows share the navigation rhythm. Topic rows show a `#` in the same icon slot as the main chat so their text starts on the same vertical line. An unread count is a 16px circle with compact 11px/16px type from the host-owned `--row-count-*` tokens, expanding to a pill for wider counts. It uses `primary/15` for the fill and a 60% `primary` mix with `foreground` in OKLab for the numeral, matching the upgrade row's contrast-safe accent ink. Its border is transparent in light mode and `primary/50` in dark mode. It occupies the icon slot until the count clears and stays visible when the row menu appears. Lists and the Tasks card share an 8px outer inset, and the Tasks heading uses the same row height. The navigation rail's search trigger is a borderless pill with a `surface-muted` fill. The medium row vertical inset separates it from the navigation group. Navigation, list glyphs, and app artwork are 16px. The Projects and Chat glyphs share a stroke width. The Apps, Chat, and Projects glyphs tilt during hover or keyboard focus. Filled artwork reads slightly larger than outline glyphs within the same fixed slots, and names stay aligned. Hover takes `surface-hover`. The selected row takes `surface`, `shadow-4`, a single 1px outer edge in `border` at 70% alpha, regular-weight text, and a `primary` glyph; dark mode uses `surface-hover`. App artwork keeps its own colors. Rows inside the Tasks card use 8px corners, matching its heading and the concentric corner rule. A selected task uses the hover fill without another shadow. Archived chats read in Subtle Ink. Unread activity is an 8px `info` dot that hides on hover to reveal the row action. Below the pinned entries, a hairline and an aux "Recent" label introduce up to three unpinned apps the guardian built or opened in the last 14 days, most recent first, with a "Show more" row for the rest. The zone is absent when empty. An installed, never-opened app carries the same 8px `info` dot, which on hover gives way to a Pin action. On touch the Pin action is always visible and the dot sits beside it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] documentation — "Share a stroke width" is imprecise for a fill-based Radix glyph

Pencil2Icon comes from @radix-ui/react-icons. Those icons are filled 15×15 paths with no SVG stroke. FolderKanban comes from lucide and draws a 2-unit stroke on a 24-unit grid, about 1.33px at 16px. So the two glyphs don't literally share a stroke width; they just look about as heavy as each other. Consider wording such as "The Projects glyph uses the default lucide stroke, matching the visual weight of Chat" so nobody later tries to tune one value to make them identical.

- **Mobile header:** 48px plus the safe-area inset, hairline bottom border, hidden from 768px up.
- **Chat search:** `Command+K` on Apple platforms and `Ctrl+K` elsewhere open a command dialog. The trigger stays visible beside the list settings, since a shortcut is never the only path. A leading `@` turns the field into an agent picker, and a picked agent pins as a composer chip before the text. From then on the field holds a message, and Enter starts a new chat with that agent in the default project. Backspace in the empty field unpins the agent.

Expand Down
36 changes: 7 additions & 29 deletions packages/web/src/globals.css
Original file line number Diff line number Diff line change
Expand Up @@ -297,21 +297,6 @@
}
}


@keyframes rome-sidebar-apps-hover {
0% {
transform: rotate(0deg) scale(1);
}

45% {
transform: rotate(-7deg) scale(1.12);
}

100% {
transform: rotate(0deg) scale(1);
}
}

[data-concierge-unread] {
--row-count-font-size: 0.6875rem;
--row-count-line-height: calc(16 / 11);
Expand All @@ -327,16 +312,14 @@
will-change: transform;
}

.rome-sidebar-icon[data-motion="chat"] {
transition: transform 150ms ease-out;
}

.rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion="apps"] {
animation: rome-sidebar-apps-hover 420ms cubic-bezier(0.16, 1, 0.3, 1);
}
@media (prefers-reduced-motion: no-preference) {
.rome-sidebar-icon[data-motion="tilt"] {
transition: transform 150ms ease-out;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] code-quality — Tilt transition replaces the span's colour transition

The span in renderBuiltinIcon also carries transition-colors. This unlayered transition shorthand wins over the Tailwind utility and leaves only transform in the transition list. Apps and Projects now snap to text-primary on selection instead of fading; before this PR only Chat did. To keep both, list the colour property too:

Suggested change
transition: transform 150ms ease-out;
transition: transform 150ms ease-out, color 150ms ease-out;

}

.rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion="chat"] {
transform: rotate(-8deg);
.rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion="tilt"] {
transform: rotate(-8deg);
}
}

/* The sidebar's upgrade row: a light tint of the theme's success green, with
Expand All @@ -363,11 +346,6 @@ button.rome-upgrade-row:hover {
.rome-sidebar-icon {
will-change: auto;
}

.rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion] {
animation: none;
transform: none;
}
}

/* Live caret: pulsing dot riding the tail of the streaming assistant bubble
Expand Down
5 changes: 1 addition & 4 deletions packages/web/src/shell/AppGrid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,7 @@ function renderBuiltinIcon(entry: BuiltinNavEntry): React.ReactNode {
data-motion={entry.sidebarIconMotion}
aria-hidden
>
<Icon
className={`h-4 w-4 shrink-0 ${entry.id === "projects" ? "stroke-[1.5]" : ""}`}
aria-hidden
/>
<Icon className="h-4 w-4 shrink-0" aria-hidden />
</span>
);
}
Expand Down
14 changes: 10 additions & 4 deletions packages/web/src/shell/builtin-nav.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface BuiltinNavEntry {
href: string;
labelKey: string;
Icon: ComponentType<{ className?: string; "aria-hidden"?: boolean }>;
sidebarIconMotion?: "apps" | "chat";
sidebarIconMotion?: "tilt";
/** Extra search terms, matched alongside the translated label and the id. */
aliases?: readonly string[];
}
Expand All @@ -29,9 +29,15 @@ export const APP_NAV: readonly BuiltinNavEntry[] = [
href: "/apps",
labelKey: "nav.apps",
Icon: DashboardIcon,
sidebarIconMotion: "apps",
sidebarIconMotion: "tilt",
},
{
id: "projects",
href: "/projects",
labelKey: "nav.projects",
Icon: FolderKanban,
sidebarIconMotion: "tilt",
},
{ id: "projects", href: "/projects", labelKey: "nav.projects", Icon: FolderKanban },
{ id: "memory", href: "/memory", labelKey: "nav.memory", Icon: ArchiveIcon },
{ id: "people", href: "/people", labelKey: "nav.people", Icon: PersonIcon },
// Off the sidebar until the guardian pins it: main answers assistants, so
Expand Down Expand Up @@ -64,7 +70,7 @@ export const APP_NAV: readonly BuiltinNavEntry[] = [
href: "/message",
labelKey: "nav.chat",
Icon: Pencil2Icon,
sidebarIconMotion: "chat",
sidebarIconMotion: "tilt",
},
{ id: "settings", href: "/settings", labelKey: "nav.settings", Icon: GearIcon },
] as const;
Loading