Repository navigation
fix(web): align sidebar icon motion and stroke weight #2365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -297,21 +297,6 @@ | |||||
| } | ||||||
| } | ||||||
|
|
||||||
|
|
||||||
| @keyframes rome-sidebar-apps-hover { | ||||||
| 0% { | ||||||
| transform: rotate(0deg) scale(1); | ||||||
| } | ||||||
|
|
||||||
| 45% { | ||||||
| transform: rotate(-7deg) scale(1.12); | ||||||
| } | ||||||
|
|
||||||
| 100% { | ||||||
| transform: rotate(0deg) scale(1); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| [data-concierge-unread] { | ||||||
| --row-count-font-size: 0.6875rem; | ||||||
| --row-count-line-height: calc(16 / 11); | ||||||
|
|
@@ -327,16 +312,14 @@ | |||||
| will-change: transform; | ||||||
| } | ||||||
|
|
||||||
| .rome-sidebar-icon[data-motion="chat"] { | ||||||
| transition: transform 150ms ease-out; | ||||||
| } | ||||||
|
|
||||||
| .rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion="apps"] { | ||||||
| animation: rome-sidebar-apps-hover 420ms cubic-bezier(0.16, 1, 0.3, 1); | ||||||
| } | ||||||
| @media (prefers-reduced-motion: no-preference) { | ||||||
| .rome-sidebar-icon[data-motion="tilt"] { | ||||||
| transition: transform 150ms ease-out; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P3] The span in
Suggested change
|
||||||
| } | ||||||
|
|
||||||
| .rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion="chat"] { | ||||||
| transform: rotate(-8deg); | ||||||
| .rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion="tilt"] { | ||||||
| transform: rotate(-8deg); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| /* The sidebar's upgrade row: a light tint of the theme's success green, with | ||||||
|
|
@@ -363,11 +346,6 @@ button.rome-upgrade-row:hover { | |||||
| .rome-sidebar-icon { | ||||||
| will-change: auto; | ||||||
| } | ||||||
|
|
||||||
| .rome-sidebar-link:is(:hover, :focus-visible) .rome-sidebar-icon[data-motion] { | ||||||
| animation: none; | ||||||
| transform: none; | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| /* Live caret: pulsing dot riding the tail of the streaming assistant bubble | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3]
documentation— "Share a stroke width" is imprecise for a fill-based Radix glyphPencil2Iconcomes from@radix-ui/react-icons. Those icons are filled 15×15 paths with no SVG stroke.FolderKanbancomes from lucide and draws a 2-unit stroke on a 24-unit grid, about 1.33px at 16px. So the two glyphs don't literally share a stroke width; they just look about as heavy as each other. Consider wording such as "The Projects glyph uses the default lucide stroke, matching the visual weight of Chat" so nobody later tries to tune one value to make them identical.