Repository navigation
fix(webchat): preserve trusted actor in Concierge task handoffs #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e890c83
fix(core): preserve actors across Concierge task inputs
Asuka109 ff5f60f
fix(webchat): preserve trusted actor in Concierge task handoffs
Asuka109 12ee799
fix(webchat): retain task handoff boundaries after main sync
Asuka109 77a43ba
fix(webchat): preserve asking device in attributed task sends
Asuka109 f91e20a
fix(core): bind task input to its originating tool callback
Asuka109 ad5cef7
fix(core): retain already-unattributed task delivery
Asuka109 eccee45
fix(core): fail queued inputs on refused attributed delivery
Asuka109 6210f67
fix(core): preserve task handoffs through same-person follow-ups
Asuka109 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3]
correctness— An automated input queued after a same-person supersede revokes a pending handoff before it runsEvery
submitobserves its scope, includingafter/nextinputs that do not supersede the running turn. Here is the race: a backend task event is waiting behind T1's stream, and the guardian sends anowfollow-up whilechat_startis cold-opening. T1's stream then finishes, and the event'ssubmit("after", actor: undefined)bumps the epoch.chat_startthen fails permanently ("Do not start it again"), even though no other identity has run in the source session. The race is narrow. Optional fix: observe atsubmitonly fornowinputs. That is the case the comment's synchronous-stop argument needs. LeaverunOneTurnandmixActorsto catch other inputs once they actually run or are steered in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed by the current submit/start path: an unattributed
afterinput can revoke a pending handoff before that input runs. I am deferring this optional availability refinement, not treating it as an identity leak. The current contract conservatively revokes when a changed scope is accepted, and refuses visibly without retry or an anonymous fallback.The suggested now-only observation is not sufficient on its own:
startTurnalso observes queuedafterwork, and anextinput can be steered into a running turn.mixActorscovers identity changes, but not a same-actor thread/audience change on that steer. Deferring scope observation would need a reliable pre-steer scope boundary as well as the run-start boundary; simply removing the current observations loses that protection. I will keep that broader queue-policy refinement outside this focused repair. The owner-authorized same-person, unchanged-scopenowcase remains covered.