Typescript plugin fails to compile the entry point when there is at least one invalid TypeScript file somewhere is the working directory

[ericmorand]

• Rollup Plugin Name: @rollup/plugin-typescript
• Rollup Plugin Version: 11.1.5
• Rollup Version: 4.9.0
• Operating System (or Browser): Ubuntu
• Node Version: 16.20
• Link to reproduction: https://github.com/ericmorand/rollup-plugin-typescript-issue-2

Expected Behavior

In the reproduction repository, we find 3 TS files:

• src/index.ts, the entry point
• src/valid.ts, imported by the entry point
• src/invalid.ts, containing non valid TypeScript syntax and imported by neither src/index.ts or src/valid.ts

When executing rollup on src/index.ts, the build should be successful since the src/invalid.ts file is not imported.

Actual Behavior

The build is unsuccessful, and the error suggests that src/invalid.ts is syntax-checked by the plugin even though it is not part of the dependency graph of the entry point:

$ npx rollup -i src/index.ts -p @rollup/plugin-typescript
npm WARN cli npm v10.2.4 does not support Node.js v16.20.2. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.

src/index.ts → stdout...
var foo = 5;

console.log(foo);
(!) Plugin typescript: @rollup/plugin-typescript TS2304: Cannot find name 'foo'.
src/invalid.ts: (1:1)

1 foo
  ~~~

Additional Information

Note that the behaviour of tsc is correct in that regard:

$ tsc src/index.ts

No error is emitted and src/index.ts and src/valid.ts are successfully compiled.

So the error is coming from the plugin, not from the TypeScript compiler.

[ericmorand]

While investigating the issue, I stumbled upon a very strange part of the code that seems to handle non-yet discovered files but always ends up throwing an error:

plugins/packages/typescript/src/index.ts

Line 157 in 33174f9

// Discovered new file that was not known when originally parsing the TypeScript config

if (!parsedOptions.fileNames.includes(fileName)) {
    // Discovered new file that was not known when originally parsing the TypeScript config
    parsedOptions.fileNames.push(fileName);
}

There, the newly discovered file is added to parsedOptions.fileNames but since it was never compiled by the TypeScript program, it is missing from emittedFiles or ts cache, and ends being considered by Rollup as non handled which triggers an error.

What is the rational that drives this part of the code? Can someone guide me to the test that covers this part of the code?

[makbol]

Hi @ericmorand, thanks for reporting this. While I see the bug report is almost 2 yrs old, I encountered the same problem. Have you found a way to get around the problem while #1653 is still under review?

[ericmorand]

I ended up coding my own plugin. Hopefully this PR - and a few others - ends up being merged and I can move back to the official one.

[stale]

Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ