Skip to content

feat: support name property#1187

Open
ari-party wants to merge 15 commits intorojo-rbx:masterfrom
ari-party:name-prop
Open

feat: support name property#1187
ari-party wants to merge 15 commits intorojo-rbx:masterfrom
ari-party:name-prop

Conversation

@ari-party
Copy link
Copy Markdown
Contributor

The Instance.Name property famously doesn't support special characters. E.g. a forward slash (/).
This causes you to be unable to have any instances in your Rojo project with special characters.

This PR:

  • Adds preference for name from .meta and .model.json files when syncing
  • Syncback now slugifies (replaces invalid characters with _) and adds the name property if slugified version doesn't equal original

Copy link
Copy Markdown

@krakow10 krakow10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid several clones.

Comment thread src/snapshot_middleware/lua.rs
Comment thread src/snapshot_middleware/json_model.rs Outdated
Comment thread src/syncback/file_names.rs Outdated
Comment thread src/syncback/file_names.rs
ari-party and others added 4 commits January 12, 2026 14:35
Co-authored-by: krakow10 <krakow20@gmail.com>
Co-authored-by: krakow10 <krakow20@gmail.com>
Co-authored-by: krakow10 <krakow20@gmail.com>
Comment thread src/syncback/mod.rs Outdated
Comment thread src/syncback/mod.rs
Comment thread src/syncback/mod.rs Outdated
Comment thread src/syncback/mod.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants