fix(agent-sdk): scope recursion guard to AsyncLocalStorage, memoize SDK import by rohitg00 · Pull Request #782 · rohitg00/agentmemory

rohitg00 · 2026-06-02T11:57:35Z

Problem

Reported in #781. mem::summarize fails with too_many_chunks_skipped: 4/4 chunks failed to parse after retry whenever the agent-sdk provider is active (AGENTMEMORY_ALLOW_AGENT_SDK=true) and a session is large enough to split into ≥2 chunks.

The two PRs interact badly:

Stop-hook → /summarize → agent-sdk infinite recursion when no provider key is set (extends #149) #181 (Stop-hook → /summarize → agent-sdk infinite recursion fix) added the guard:
```
if (process.env.AGENTMEMORY_SDK_CHILD === '1') return ''
process.env.AGENTMEMORY_SDK_CHILD = '1'
// ...await SDK...
// restore in finally
```
fix(summarize): chunk large sessions to fit LLM context window #472 (chunk large sessions to fit LLM context) added chunk concurrency:
```
for (let i = 0; i < chunks.length; i += concurrency) {
  await Promise.all(batch.map(/* provider.summarize */));
}
```

The first chunk in a batch flips the env synchronously before its first await. Sibling chunks in the same batch enter query(), see the flag, and return "". Empty string has no <title>, parseSummaryXml returns null, the chunk is counted as skipped, > 50% skip ratio throws.

The guard (cross-process) and the chunk concurrency (in-process) were never reconciled.

Fix — split the guard by scope

Each concern uses the right primitive:

Concern	Primitive	Why
In-process recursion (concurrent siblings)	`AsyncLocalStorage`	Scoped to the async call tree of the SDK query. Concurrent siblings have separate ALS frames, no longer see each other's marker.
Cross-process recursion (hook scripts)	`process.env.AGENTMEMORY_SDK_CHILD = '1'` around the SDK call	Hook scripts run as separate processes spawned by the Claude SDK; they inherit `process.env` at spawn time. ALS does not cross process boundaries.

The check now reads sdkChildContext.getStore() instead of process.env. The env var stays set+restored around the SDK call so spawned hook subprocesses still see the marker and short-circuit their REST callbacks (the original #149/#181 fix still holds).

The race on the env between concurrent in-process siblings is benign because every sibling wants "1" during its own SDK call anyway.

Bonus: memoize the dynamic import

Refactored await import('@anthropic-ai/claude-agent-sdk') into a per-instance memoized promise. Concurrent callers share one module resolution. Two benefits:

Production: one resolution per provider lifetime instead of N
Test: vi.mock factories apply uniformly across concurrent imports (without this, the test mock raced with real module references under Promise.all, see commit body)

Tests

5 cases in test/agent-sdk-provider.test.ts:

4 concurrent summarize calls each return the real SDK result (no empty siblings) — direct agent-sdk: global process.env AGENTMEMORY_SDK_CHILD recursion guard races with concurrent summarize chunks → too_many_chunks_skipped #781 regression
Mixed concurrent summarize + compress on the same provider
AGENTMEMORY_SDK_CHILD is set to "1" during the SDK call (verified by reading the env from inside the mocked query) and restored to its prior value on exit
Genuine re-entry inside the same async tree still degrades to "" so the 429 rate limit errors when AUTO_COMPRESS uses agent-sdk provider in a heavy Claude Code session #149 / Stop-hook → /summarize → agent-sdk infinite recursion when no provider key is set (extends #149) #181 recursion guard stays armed

Full suite: 122 files / 1331 tests pass.

Recommended user action

Users on 0.9.24 can remove the SUMMARIZE_CHUNK_CONCURRENCY=1 workaround after this lands. No env or config changes required.

Closes #781.

Summary by CodeRabbit

Bug Fixes
- Improved handling of concurrent memory operations to prevent re-entrancy and state leakage during overlapping calls.
Performance Improvements
- Reduced repeated SDK initialization by caching the SDK load for faster subsequent calls.
Tests
- Added coverage validating concurrency behavior and guard correctness.

…DK import Reported in #781. mem::summarize fails with 'too_many_chunks_skipped: 4/4 chunks failed to parse after retry' on the agent-sdk provider whenever a session is large enough to split into >=2 chunks. Root cause: the recursion guard from #181 mutated process.env globally: if (process.env.AGENTMEMORY_SDK_CHILD === '1') return '' process.env.AGENTMEMORY_SDK_CHILD = '1' // ...await SDK... // restore #472 then introduced chunked summarize that runs chunks concurrently via Promise.all (SUMMARIZE_CHUNK_CONCURRENCY=6 by default). The first chunk in a batch flips the env synchronously before its first await; siblings in the same batch then enter query(), see the flag, and return ''. An empty string has no <title>, parseSummaryXml returns null, the chunk is counted as skipped, >50% skip ratio throws too_many_chunks_skipped. The guard (cross-process) and the chunk concurrency (in-process) were never reconciled. Each needs the right primitive: - In-process recursion guard: AsyncLocalStorage. Scoped to the async call tree of the SDK query, so concurrent siblings have separate ALS frames and no longer see each other's marker. The check now reads sdkChildContext.getStore() instead of process.env. - Cross-process recursion guard for hook scripts: still process.env.AGENTMEMORY_SDK_CHILD = '1' around the SDK call. Subprocesses spawned by @anthropic-ai/claude-agent-sdk inherit process.env at spawn time; hook scripts (separate processes) still read the env to short-circuit their REST callbacks. The race on the env between concurrent in-process siblings is benign because every sibling wants the same value '1' during its own SDK call. Also memoize the dynamic import of @anthropic-ai/claude-agent-sdk on the provider instance. Production benefit: concurrent callers share one module resolution. Test benefit: vi.mock factories apply uniformly across concurrent imports instead of racing between mock and real module references. Tests cover: - 4 concurrent summarize calls each return the real SDK result (no empty siblings) — the direct #781 regression - Mixed concurrent summarize + compress on the same provider - AGENTMEMORY_SDK_CHILD is set to '1' during the SDK call (child process inheritance) and restored to the prior value on exit - Genuine re-entry inside the same async tree still degrades to '' so the #149 / #181 stop-hook -> summarize recursion stays broken Closes #781.

vercel · 2026-06-02T11:57:38Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agentmemory	Ready	Preview, Comment	Jun 2, 2026 3:11pm

coderabbitai · 2026-06-02T11:57:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d8d8c15-4cdf-4ae2-913f-b61935eda702

📥 Commits

Reviewing files that changed from the base of the PR and between 829888c and 75264f2.

📒 Files selected for processing (2)

src/providers/agent-sdk.ts
test/agent-sdk-provider.test.ts

🚧 Files skipped from review as they are similar to previous changes (2)

src/providers/agent-sdk.ts
test/agent-sdk-provider.test.ts

📝 Walkthrough

Walkthrough

AgentSDKProvider now uses AsyncLocalStorage to short-circuit in-process re-entry and a reference-counted env marker to preserve cross-process inheritance. The Claude SDK import is memoized via a cached promise. Tests verify concurrent summarize/compress behavior, env preservation/restoration, and genuine re-entry returns "" for inner calls.

Changes

Recursion Guard and SDK Memoization

Layer / File(s)	Summary
AsyncLocalStorage infrastructure and SDK memoization `src/providers/agent-sdk.ts`	Adds an AsyncLocalStorage instance and a memoized private `loadSdk()` (cached `sdkPromise`) to avoid per-call dynamic imports.
Query method with in-process guard and env var handling `src/providers/agent-sdk.ts`	`query()` short-circuits with `""` when the ALS store indicates in-process re-entrancy, runs SDK calls inside `AsyncLocalStorage.run(...)`, and uses module-level `sdkActiveCount` and `sdkOriginalEnv` to set/restore `process.env.AGENTMEMORY_SDK_CHILD` safely across overlapping calls while using `loadSdk()`.
Test suite for recursion guard and concurrency `test/agent-sdk-provider.test.ts`	Adds Vitest mocks for `@anthropic-ai/claude-agent-sdk.query` and tests: multiple concurrent `summarize` calls, concurrent `compress`+`summarize`, env variable observed as `"1"` during SDK execution and restored after, preservation of prior env values, full-overlap env persistence across concurrent calls, and genuine in-tree re-entry returning `""` for the inner call.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 In async groves the guards once fought,
Now local stores keep each branch taught.
Env flags rise, then gently fall,
The SDK loads just once for all.
Chunks hum true, no sibling’s plight—
Rabbit cheers: concurrency sleeps tight. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the two main fixes: moving the recursion guard to AsyncLocalStorage and memoizing the SDK import.
Linked Issues check	✅ Passed	All primary objectives from `#781` are met: recursion guard scoped to AsyncLocalStorage for in-process calls [`#781`], cross-process env marker preserved [`#781`], SDK import memoized [`#781`], and comprehensive tests added [`#781`].
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the recursion guard race in AgentSDKProvider and adding test coverage; no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/agent-sdk-recursion-guard-als

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/providers/agent-sdk.ts`:
- Around line 74-100: The current per-call snapshot of
process.env.AGENTMEMORY_SDK_CHILD races across overlapping calls; replace it
with shared active-call accounting: introduce a module-level counter (e.g.,
sdkActiveCount) and a single stored original value (e.g., sdkOriginalEnv) and on
entry (in the method around the existing prev/save block) increment
sdkActiveCount and, if it becomes 1, save process.env.AGENTMEMORY_SDK_CHILD into
sdkOriginalEnv and set process.env.AGENTMEMORY_SDK_CHILD = '1'; in the finally
block decrement sdkActiveCount and only when it reaches 0 restore
process.env.AGENTMEMORY_SDK_CHILD from sdkOriginalEnv (delete if undefined) so
the original value is preserved until the last active SDK call exits; keep the
existing loadSdk/query/result logic intact and ensure the counter and original
value are module-scoped so concurrent invocations of the function share them.

In `@test/agent-sdk-provider.test.ts`:
- Around line 8-30: The mock factory for vi.mock is hoisted and currently
captures top-level bindings queryCalls and mockResult; move those into a hoisted
state by creating a vi.hoisted(() => ({ queryCalls, mockResult })) object and
update the mock factory to reference state.queryCalls and state.mockResult (and
update beforeEach/assertions to use state.queryCalls/state.mockResult) so the
mock does not close over non-hoisted module-scope variables; keep the mock
implementation in the same function (query) but replace direct uses of
queryCalls and mockResult with the hoisted state fields.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bba5211a-4454-4db8-81a0-f6fb07c35660

📥 Commits

Reviewing files that changed from the base of the PR and between de95403 and 829888c.

📒 Files selected for processing (2)

src/providers/agent-sdk.ts
test/agent-sdk-provider.test.ts

Address CodeRabbit findings on PR #782. agent-sdk.ts: the per-call prev snapshot races across overlapping calls. Trace: - A enters: prev=undef, env='1' - B enters: prev='1' (already set by A), env='1' - A finishes first, restores prev=undef -> env=undef WHILE B is still mid-flight; any child process B spawns now won't inherit the marker - B finishes, restores prev='1' -> env='1' leaks past the last caller Replace with module-level reference counting: let sdkActiveCount = 0 let sdkOriginalEnv: string | undefined if (sdkActiveCount === 0) { sdkOriginalEnv = process.env.AGENTMEMORY_SDK_CHILD process.env.AGENTMEMORY_SDK_CHILD = '1' } sdkActiveCount++ try { ...SDK call... } finally { sdkActiveCount-- if (sdkActiveCount === 0) { // restore sdkOriginalEnv (delete if undefined) } } Only the first entrant snapshots the original; only the last exit restores it. Env stays '1' for the full overlap. test/agent-sdk-provider.test.ts: vi.mock factories are hoisted above const/let bindings, so the closure can't safely reference non-hoisted module-scope state. Move queryCalls and mockResult into a vi.hoisted state object so the mock factory and tests share an explicitly hoisted reference instead of a closure capture. Also fixed a test-mock bug while adding the overlap regression: the mock yielded the unwrapped Promise from a function-shaped mockResult. The gen now awaits the mockResult inside the generator so async mock results are unwrapped before yielding. New regression test: 3 concurrent calls each observe AGENTMEMORY_SDK_CHILD='1' at enter and exit phases for the full overlap, and env is restored to undefined only after the last call finishes. 122 test files / 1332 tests pass.

Bump to 0.9.25 across 9 files + CHANGELOG. Closes #778 #775 #783 (PR #791), #758 #726 (PR #773), #759 (PR #772), #752 (PR #774), #729 (PR #780), #781 (PR #782), #753 (PR #789), #771 (PR #786), #762 (PR #764). Files bumped: - package.json - packages/mcp/package.json - plugin/.claude-plugin/plugin.json - plugin/.codex-plugin/plugin.json - plugin/plugin.json - src/version.ts - src/types.ts (ExportData.version union) - src/functions/export-import.ts (supportedVersions Set) - test/export-import.test.ts (assertion) 125 test files / 1379 tests pass. npm audit (root + website): 0 vulns.

…DK import (rohitg00#782) * fix(agent-sdk): scope recursion guard to AsyncLocalStorage, memoize SDK import Reported in rohitg00#781. mem::summarize fails with 'too_many_chunks_skipped: 4/4 chunks failed to parse after retry' on the agent-sdk provider whenever a session is large enough to split into >=2 chunks. Root cause: the recursion guard from rohitg00#181 mutated process.env globally: if (process.env.AGENTMEMORY_SDK_CHILD === '1') return '' process.env.AGENTMEMORY_SDK_CHILD = '1' // ...await SDK... // restore rohitg00#472 then introduced chunked summarize that runs chunks concurrently via Promise.all (SUMMARIZE_CHUNK_CONCURRENCY=6 by default). The first chunk in a batch flips the env synchronously before its first await; siblings in the same batch then enter query(), see the flag, and return ''. An empty string has no <title>, parseSummaryXml returns null, the chunk is counted as skipped, >50% skip ratio throws too_many_chunks_skipped. The guard (cross-process) and the chunk concurrency (in-process) were never reconciled. Each needs the right primitive: - In-process recursion guard: AsyncLocalStorage. Scoped to the async call tree of the SDK query, so concurrent siblings have separate ALS frames and no longer see each other's marker. The check now reads sdkChildContext.getStore() instead of process.env. - Cross-process recursion guard for hook scripts: still process.env.AGENTMEMORY_SDK_CHILD = '1' around the SDK call. Subprocesses spawned by @anthropic-ai/claude-agent-sdk inherit process.env at spawn time; hook scripts (separate processes) still read the env to short-circuit their REST callbacks. The race on the env between concurrent in-process siblings is benign because every sibling wants the same value '1' during its own SDK call. Also memoize the dynamic import of @anthropic-ai/claude-agent-sdk on the provider instance. Production benefit: concurrent callers share one module resolution. Test benefit: vi.mock factories apply uniformly across concurrent imports instead of racing between mock and real module references. Tests cover: - 4 concurrent summarize calls each return the real SDK result (no empty siblings) — the direct rohitg00#781 regression - Mixed concurrent summarize + compress on the same provider - AGENTMEMORY_SDK_CHILD is set to '1' during the SDK call (child process inheritance) and restored to the prior value on exit - Genuine re-entry inside the same async tree still degrades to '' so the rohitg00#149 / rohitg00#181 stop-hook -> summarize recursion stays broken Closes rohitg00#781. * fix(agent-sdk): refcount env marker + vi.hoisted mock state Address CodeRabbit findings on PR rohitg00#782. agent-sdk.ts: the per-call prev snapshot races across overlapping calls. Trace: - A enters: prev=undef, env='1' - B enters: prev='1' (already set by A), env='1' - A finishes first, restores prev=undef -> env=undef WHILE B is still mid-flight; any child process B spawns now won't inherit the marker - B finishes, restores prev='1' -> env='1' leaks past the last caller Replace with module-level reference counting: let sdkActiveCount = 0 let sdkOriginalEnv: string | undefined if (sdkActiveCount === 0) { sdkOriginalEnv = process.env.AGENTMEMORY_SDK_CHILD process.env.AGENTMEMORY_SDK_CHILD = '1' } sdkActiveCount++ try { ...SDK call... } finally { sdkActiveCount-- if (sdkActiveCount === 0) { // restore sdkOriginalEnv (delete if undefined) } } Only the first entrant snapshots the original; only the last exit restores it. Env stays '1' for the full overlap. test/agent-sdk-provider.test.ts: vi.mock factories are hoisted above const/let bindings, so the closure can't safely reference non-hoisted module-scope state. Move queryCalls and mockResult into a vi.hoisted state object so the mock factory and tests share an explicitly hoisted reference instead of a closure capture. Also fixed a test-mock bug while adding the overlap regression: the mock yielded the unwrapped Promise from a function-shaped mockResult. The gen now awaits the mockResult inside the generator so async mock results are unwrapped before yielding. New regression test: 3 concurrent calls each observe AGENTMEMORY_SDK_CHILD='1' at enter and exit phases for the full overlap, and env is restored to undefined only after the last call finishes. 122 test files / 1332 tests pass.

Bump to 0.9.25 across 9 files + CHANGELOG. Closes rohitg00#778 rohitg00#775 rohitg00#783 (PR rohitg00#791), rohitg00#758 rohitg00#726 (PR rohitg00#773), rohitg00#759 (PR rohitg00#772), rohitg00#752 (PR rohitg00#774), rohitg00#729 (PR rohitg00#780), rohitg00#781 (PR rohitg00#782), rohitg00#753 (PR rohitg00#789), rohitg00#771 (PR rohitg00#786), rohitg00#762 (PR rohitg00#764). Files bumped: - package.json - packages/mcp/package.json - plugin/.claude-plugin/plugin.json - plugin/.codex-plugin/plugin.json - plugin/plugin.json - src/version.ts - src/types.ts (ExportData.version union) - src/functions/export-import.ts (supportedVersions Set) - test/export-import.test.ts (assertion) 125 test files / 1379 tests pass. npm audit (root + website): 0 vulns.

vercel Bot deployed to Preview June 2, 2026 11:57

View deployment

coderabbitai Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread src/providers/agent-sdk.ts Outdated

Comment thread test/agent-sdk-provider.test.ts Outdated

vercel Bot deployed to Preview June 2, 2026 15:11

View deployment

rohitg00 merged commit fc068be into main Jun 2, 2026
7 checks passed

rohitg00 deleted the fix/agent-sdk-recursion-guard-als branch June 2, 2026 16:20

coderabbitai Bot mentioned this pull request Jun 16, 2026

fix(cli): Bun Windows compatibility — shell:true child_process workaround and iii-exec config #917

Closed

Navigation Menu

Repository navigation

fix(agent-sdk): scope recursion guard to AsyncLocalStorage, memoize SDK import - #782

fix(agent-sdk): scope recursion guard to AsyncLocalStorage, memoize SDK import#782
rohitg00 merged 2 commits into
mainfrom
fix/agent-sdk-recursion-guard-als

rohitg00 commented Jun 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Jun 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

rohitg00 commented Jun 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Fix — split the guard by scope

Bonus: memoize the dynamic import

Tests

Recommended user action

Summary by CodeRabbit

Uh oh!

vercel Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rohitg00 commented Jun 2, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Jun 2, 2026 •

edited

Loading

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading