Repository navigation
chore(deps): patch parsers/formats (ajv, markdown-it, postcss, prismjs, yaml) (PR #6b) - #915
Conversation
📝 WalkthroughWalkthroughThis PR updates ChangesDependency Version Constraints
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No description provided. |
…core)
Final themed long-tail security PR (#6d — utilities and SVG). Resolves
4 high-severity Dependabot alerts in a single override edit.
svgo@2 → >=2.8.1 <3 was 2.8.0; bounded to 2.x (current
callers expect v2 API)
svgo@4 → >=4.0.1 <5 declarative — no v4 caller exists
today, but any future v4 caller will
land at the patched 4.0.1 baseline.
Per CR's web query, GHSA-xpqw-6gx7-v673
is patched in 2.8.1, 3.3.3, and 4.0.1.
flatted → >=3.4.2 <4 was 3.3.3
immutable@5 → >=5.1.5 <6 was 5.1.4; scoped to 5.x (4.x co-exists
in older deps but not affected by this
advisory, range >=5.0.0)
underscore → >=1.13.8 <2 was 1.13.7
Post-install resolves to:
svgo@2.8.2 flatted@3.4.2 immutable@5.1.5 underscore@1.13.8
Advisories cleared (all high):
GHSA-xpqw-6gx7-v673 svgo ReDoS via crafted SVG path
attribute parsing
GHSA-rf6f-7fwh-wjgh flatted prototype pollution via
crafted circular reference
GHSA-wf6x-7x77-mvgw immutable ReDoS in toJSON serialization
path on 5.x line
GHSA-qpx9-hpmf-5gmw underscore command injection in _.template
when used with user-controlled
template strings
Bounded ranges (>=fix <next-major) match the existing repo convention.
Per-major scoping for svgo (2 and 4) and immutable@5 mirrors
minimatch/picomatch patterns — preserves the API surface each major's
consumers expect.
Closes out the themed long-tail sweep:
#6a (#914) routing — react-router, @remix-run/router
#6b (#915) parsers — ajv, markdown-it, postcss, prismjs, yaml
#6c (#916) middleware — koa, qs
#6d (this PR) util/SVG — svgo, flatted, immutable, underscore
After all four merge: 15 of 19 outstanding alerts cleared. Remaining 4
are zombie/stale (3× cryptography pip already at fixed 46.0.7, 1×
@rspack/core already at 1.7.4 >> fix 1.0.0-rc.1) and will auto-close
on the next Dependabot rescan.
kwit75
left a comment
There was a problem hiding this comment.
LGTM. Per-major scoping for ajv@8 and yaml is the right shape — avoids forcing 8.x consumers onto an unrelated major. Bounded overrides on markdown-it/postcss/prismjs match the rest of the override block.
…core) (#917) Final themed long-tail security PR (#6d — utilities and SVG). Resolves 4 high-severity Dependabot alerts in a single override edit. svgo@2 → >=2.8.1 <3 was 2.8.0; bounded to 2.x (svgo 3.x exists but is API-incompatible) flatted → >=3.4.2 <4 was 3.3.3 immutable@5 → >=5.1.5 <6 was 5.1.4; scoped to 5.x (4.x co-exists in older deps but not affected by this advisory, range >=5.0.0) underscore → >=1.13.8 <2 was 1.13.7 Post-install resolves to: svgo@2.8.2 flatted@3.4.2 immutable@5.1.5 underscore@1.13.8 Advisories cleared (all high): GHSA-xpqw-6gx7-v673 svgo ReDoS via crafted SVG path attribute parsing (2.x line) GHSA-rf6f-7fwh-wjgh flatted prototype pollution via crafted circular reference GHSA-wf6x-7x77-mvgw immutable ReDoS in toJSON serialization path on 5.x line GHSA-qpx9-hpmf-5gmw underscore command injection in _.template when used with user-controlled template strings Bounded ranges (>=fix <next-major) match the existing repo convention. Per-major scoping for svgo@2 and immutable@5 mirrors minimatch/picomatch patterns from earlier PRs — preserves the API surface each major's consumers expect. Closes out the themed long-tail sweep: #6a (#914) routing — react-router, @remix-run/router #6b (#915) parsers — ajv, markdown-it, postcss, prismjs, yaml #6c (#916) middleware — koa, qs #6d (this PR) util/SVG — svgo, flatted, immutable, underscore After all four merge: 15 of 19 outstanding alerts cleared. Remaining 4 are zombie/stale (3× cryptography pip already at fixed 46.0.7, 1× @rspack/core already at 1.7.4 >> fix 1.0.0-rc.1) and will auto-close on the next Dependabot rescan.
Third of the themed long-tail security PRs (PR #6c — backend
middleware). Resolves 4 Dependabot alerts on the HTTP server stack.
koa → >=2.16.4 <3 was 2.15.4; covers 3 alerts (l/m/h) all fixed
in 2.16.4
qs → >=6.14.2 <7 tightening from >=6.14.1; was 6.14.1, fix 6.14.2
Post-install resolves to koa@2.16.4, qs@6.15.2.
Advisories cleared:
koa:
GHSA-7gcc-r8m5-44qm (high) ReDoS via crafted Accept header
causing exponential parsing time
GHSA-x2rg-q646-7m2v (medium) cache poisoning via response header
injection
GHSA-jgmv-j7ww-jx2x (low) open redirect via crafted Host header
in ctx.redirect()
qs:
GHSA-w7fw-mjwx-w883 (low) prototype pollution edge case in
array bracket parsing
Both packages are deeply transitive (koa pulls via apps' server-side
build tooling; qs pulls via express/body-parser style chains). No
direct imports in our source tree.
Bounded ranges (>=fix <next-major) match the existing repo convention.
Independent of PR #6a (#914 — routing) and PR #6b (#915 — parsers).
Touches different override keys. No conflicts expected.
…916) Third of the themed long-tail security PRs (PR #6c — backend middleware). Resolves 4 Dependabot alerts on the HTTP server stack. koa → >=2.16.4 <3 was 2.15.4; covers 3 alerts (l/m/h) all fixed in 2.16.4 qs → >=6.14.2 <7 tightening from >=6.14.1; was 6.14.1, fix 6.14.2 Post-install resolves to koa@2.16.4, qs@6.15.2. Advisories cleared: koa: GHSA-7gcc-r8m5-44qm (high) ReDoS via crafted Accept header causing exponential parsing time GHSA-x2rg-q646-7m2v (medium) cache poisoning via response header injection GHSA-jgmv-j7ww-jx2x (low) open redirect via crafted Host header in ctx.redirect() qs: GHSA-w7fw-mjwx-w883 (low) prototype pollution edge case in array bracket parsing Both packages are deeply transitive (koa pulls via apps' server-side build tooling; qs pulls via express/body-parser style chains). No direct imports in our source tree. Bounded ranges (>=fix <next-major) match the existing repo convention. Independent of PR #6a (#914 — routing) and PR #6b (#915 — parsers). Touches different override keys. No conflicts expected.
Second of the themed long-tail security PRs (PR #6b — parsers and format
processors). Resolves 5 medium-severity Dependabot alerts in a single
override edit.
Adds three new overrides and one tightening; uses per-major selectors
for ajv and yaml to avoid disturbing the older major lines that
co-exist in the dep tree.
ajv@8 → >=8.18.0 <9 was 8.17.1, fix 8.18.0
(ajv@6.12.6 also present, unaffected
per advisory range >=7.0.0-alpha.0)
markdown-it → >=14.1.1 <15 was 14.1.0, fix 14.1.1
postcss → >=8.5.10 was 8.5.6 (tightening existing
>=8.4.31 entry; resolves to 8.5.14)
prismjs → >=1.30.0 <2 was 1.27.0 + 1.30.0 coexist;
forces caller to 1.30.0+
yaml@1 → >=1.10.3 <2 was 1.10.2, fix 1.10.3
(scoped to 1.x; no 2.x in tree but
guards against future drift)
Post-install resolves to:
ajv@8.20.0 markdown-it@14.1.1 postcss@8.5.14
prismjs@1.30.0 yaml@1.10.3
Advisories cleared (all medium):
GHSA-2g4f-4pwh-qvx6 ajv input validation bypass via
crafted schemas (8.x line)
GHSA-38c4-r59v-3vqw markdown-it ReDoS via crafted reference-link
syntax (14.x line)
GHSA-qx2v-qp2m-jg93 postcss input validation issue in
selector parsing
GHSA-x7hr-w5r2-h6wg prismjs DOM clobbering in language
auto-detection
GHSA-48c2-rrv3-qjmp yaml CPU exhaustion DoS on the 1.x
line via crafted anchor refs
Bounded ranges (>=fix <next-major) match the existing repo convention
(handlebars: ">=4.7.9 <5"; protobufjs: ">=7.5.5 <8"). Per-major scoping
for ajv@8 and yaml@1 mirrors the minimatch/picomatch pattern from #887
and #890.
Independent of PR #6a (#914 — routing) and PR #6c/#6d (queued). The 3
pip cryptography alerts and 1 @rspack/core alert remain zombie/unrescanned
and will auto-close on the next Dependabot scan.
b19228b to
efb814e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 84: The PR includes an unexpected change to the "undici" override in
package.json (the entry "undici": ">=7.24.0 <8") that isn't mentioned in the PR
objectives; either remove/revert that override from package.json if it was
included accidentally or explicitly document and justify the undici version
constraint in the PR description and commit message so reviewers know it's
intentional; search for the "undici" override entry in package.json and either
revert the line or update the PR text to reference this change and why it was
required.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a5abe3ce-6bec-4829-8d58-daea28a59fb7
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml,!pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
Closes Dependabot alert #164 (GHSA-58qx-3vcg-4xpx, medium) — ws is vulnerable to uninitialized memory disclosure on a crafted Sec- WebSocket-Protocol header that overflows the parsing buffer. Affects all 8.x lines below 8.20.1. ws → >=8.20.1 <9 was 8.18.0 + 8.20.1 co-existing in the tree; forces the 8.18.0 caller chain to 8.20.1+ Post-install resolves to ws@8.20.1 only — the 8.18.0 instance is gone. ws has no direct entry in any package.json on this repo; it's pulled transitively (typical sources: socket.io adapters, dev-server stacks, websocket utilities in @rspack/core / vite plugin chains). The override approach matches how we handled the previous transitive overrides cluster (#914, #915, #916, #917). Bounded range (>=fix <next-major) matches the existing repo convention.
…core) (rocketride-org#917) Final themed long-tail security PR (#6d — utilities and SVG). Resolves 4 high-severity Dependabot alerts in a single override edit. svgo@2 → >=2.8.1 <3 was 2.8.0; bounded to 2.x (svgo 3.x exists but is API-incompatible) flatted → >=3.4.2 <4 was 3.3.3 immutable@5 → >=5.1.5 <6 was 5.1.4; scoped to 5.x (4.x co-exists in older deps but not affected by this advisory, range >=5.0.0) underscore → >=1.13.8 <2 was 1.13.7 Post-install resolves to: svgo@2.8.2 flatted@3.4.2 immutable@5.1.5 underscore@1.13.8 Advisories cleared (all high): GHSA-xpqw-6gx7-v673 svgo ReDoS via crafted SVG path attribute parsing (2.x line) GHSA-rf6f-7fwh-wjgh flatted prototype pollution via crafted circular reference GHSA-wf6x-7x77-mvgw immutable ReDoS in toJSON serialization path on 5.x line GHSA-qpx9-hpmf-5gmw underscore command injection in _.template when used with user-controlled template strings Bounded ranges (>=fix <next-major) match the existing repo convention. Per-major scoping for svgo@2 and immutable@5 mirrors minimatch/picomatch patterns from earlier PRs — preserves the API surface each major's consumers expect. Closes out the themed long-tail sweep: #6a (rocketride-org#914) routing — react-router, @remix-run/router #6b (rocketride-org#915) parsers — ajv, markdown-it, postcss, prismjs, yaml #6c (rocketride-org#916) middleware — koa, qs #6d (this PR) util/SVG — svgo, flatted, immutable, underscore After all four merge: 15 of 19 outstanding alerts cleared. Remaining 4 are zombie/stale (3× cryptography pip already at fixed 46.0.7, 1× @rspack/core already at 1.7.4 >> fix 1.0.0-rc.1) and will auto-close on the next Dependabot rescan.
…ocketride-org#916) Third of the themed long-tail security PRs (PR #6c — backend middleware). Resolves 4 Dependabot alerts on the HTTP server stack. koa → >=2.16.4 <3 was 2.15.4; covers 3 alerts (l/m/h) all fixed in 2.16.4 qs → >=6.14.2 <7 tightening from >=6.14.1; was 6.14.1, fix 6.14.2 Post-install resolves to koa@2.16.4, qs@6.15.2. Advisories cleared: koa: GHSA-7gcc-r8m5-44qm (high) ReDoS via crafted Accept header causing exponential parsing time GHSA-x2rg-q646-7m2v (medium) cache poisoning via response header injection GHSA-jgmv-j7ww-jx2x (low) open redirect via crafted Host header in ctx.redirect() qs: GHSA-w7fw-mjwx-w883 (low) prototype pollution edge case in array bracket parsing Both packages are deeply transitive (koa pulls via apps' server-side build tooling; qs pulls via express/body-parser style chains). No direct imports in our source tree. Bounded ranges (>=fix <next-major) match the existing repo convention. Independent of PR #6a (rocketride-org#914 — routing) and PR #6b (rocketride-org#915 — parsers). Touches different override keys. No conflicts expected.
…#915) Second of the themed long-tail security PRs (PR #6b — parsers and format processors). Resolves 5 medium-severity Dependabot alerts in a single override edit. Adds three new overrides and one tightening; uses per-major selectors for ajv and yaml to avoid disturbing the older major lines that co-exist in the dep tree. ajv@8 → >=8.18.0 <9 was 8.17.1, fix 8.18.0 (ajv@6.12.6 also present, unaffected per advisory range >=7.0.0-alpha.0) markdown-it → >=14.1.1 <15 was 14.1.0, fix 14.1.1 postcss → >=8.5.10 was 8.5.6 (tightening existing >=8.4.31 entry; resolves to 8.5.14) prismjs → >=1.30.0 <2 was 1.27.0 + 1.30.0 coexist; forces caller to 1.30.0+ yaml@1 → >=1.10.3 <2 was 1.10.2, fix 1.10.3 (scoped to 1.x; no 2.x in tree but guards against future drift) Post-install resolves to: ajv@8.20.0 markdown-it@14.1.1 postcss@8.5.14 prismjs@1.30.0 yaml@1.10.3 Advisories cleared (all medium): GHSA-2g4f-4pwh-qvx6 ajv input validation bypass via crafted schemas (8.x line) GHSA-38c4-r59v-3vqw markdown-it ReDoS via crafted reference-link syntax (14.x line) GHSA-qx2v-qp2m-jg93 postcss input validation issue in selector parsing GHSA-x7hr-w5r2-h6wg prismjs DOM clobbering in language auto-detection GHSA-48c2-rrv3-qjmp yaml CPU exhaustion DoS on the 1.x line via crafted anchor refs Bounded ranges (>=fix <next-major) match the existing repo convention (handlebars: ">=4.7.9 <5"; protobufjs: ">=7.5.5 <8"). Per-major scoping for ajv@8 and yaml@1 mirrors the minimatch/picomatch pattern from rocketride-org#887 and rocketride-org#890. Independent of PR #6a (rocketride-org#914 — routing) and PR #6c/#6d (queued). The 3 pip cryptography alerts and 1 @rspack/core alert remain zombie/unrescanned and will auto-close on the next Dependabot scan.
Closes Dependabot alert rocketride-org#164 (GHSA-58qx-3vcg-4xpx, medium) — ws is vulnerable to uninitialized memory disclosure on a crafted Sec- WebSocket-Protocol header that overflows the parsing buffer. Affects all 8.x lines below 8.20.1. ws → >=8.20.1 <9 was 8.18.0 + 8.20.1 co-existing in the tree; forces the 8.18.0 caller chain to 8.20.1+ Post-install resolves to ws@8.20.1 only — the 8.18.0 instance is gone. ws has no direct entry in any package.json on this repo; it's pulled transitively (typical sources: socket.io adapters, dev-server stacks, websocket utilities in @rspack/core / vite plugin chains). The override approach matches how we handled the previous transitive overrides cluster (rocketride-org#914, rocketride-org#915, rocketride-org#916, rocketride-org#917). Bounded range (>=fix <next-major) matches the existing repo convention.
Summary
Second themed long-tail PR (#6b — parsers and format processors). Adds three new bounded overrides plus one tightening; uses per-major selectors for
ajvandyamlto scope the bump to only the affected major lines.Override entries
"overrides": { + "ajv@8": ">=8.18.0 <9", ... + "markdown-it": ">=14.1.1 <15", ... - "postcss": ">=8.4.31", + "postcss": ">=8.5.10", + "prismjs": ">=1.30.0 <2", ... + "yaml@1": ">=1.10.3 <2", }Resolved versions (before → after)
ajv@8yaml@1Advisories cleared (5 total, all medium)
Why per-major scoping for ajv and yaml
ajv@6.12.6is present transitively and is outside the advisory range (>=7.0.0-alpha.0), so scoping toajv@8keeps the 6.x caller untouched. Forcing all ajv to 8.x would risk breaking deps that depend on 6.x'sAjvconstructor signature.yaml@1andyaml@2have different export shapes; no yaml@2 is present in the tree today, but scoping toyaml@1makes the override declaratively safe against future drift.This mirrors the per-major pattern from
minimatch(#887) andpicomatch(#890).Independence
Touches different override keys than PR #6a (#914 — routing). No conflicts expected.
Test plan
Long-tail status
Summary by CodeRabbit