Repository navigation
fix(nodes): remove llm_vertex, fix llm_gemini key handling, migrate vision nodes to LLMBase - #902
Conversation
…ision nodes to LLMBase
- Remove deprecated llm_vertex node (Vertex AI now supported via llm_gemini)
- Fix llm_gemini API key validation: drop strict startsWith('AI') check, add
sub-key fallback for old pipe files where sub-key is profile.split('_',1)[1]
- Fix llm_gemini validateConfig to early-return when apikey is empty (secure
fields are not decrypted at validate time)
- Migrate llm_vision_gemini and llm_vision_openai IInstance from deprecated
IInstanceGenericLLM to ai.common.llm_base.LLMBase
- Remove startsWith('AI') key format check from gemini_vision.py
- Remove vertex icon from UI icon map and asset bundle
- Hide modelSource field in services.common.llm.json (was readonly)
- Bump client-typescript SDK version to 1.1.0
- Update test mocks to remove langchain_google_vertexai mock
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No description provided. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRemoves Vertex AI artifacts; renames Gemini profiles to underscore IDs; Chat derives API keys from profile fallback and IGlobal minimal probe short-circuits; vision IInstance classes rebase to shared LLMBase; SDK/UI/version and auth/token extraction tweaks. ChangesVertex AI Removal and Gemini Modernization
Sequence Diagram(s)sequenceDiagram
participant IGlobal as IGlobal.beginGlobal()
participant Chat as Chat.__init__
participant ConnConfig as connConfig
participant SubProfile as subprofile lookup
IGlobal->>Chat: Chat(connConfig)
Chat->>ConnConfig: get('profile') (e.g. 'gemini-2_5-pro')
ConnConfig-->>Chat: profile string
Chat->>SubProfile: extract substring after first '_' (e.g. '2_5-pro' -> '5-pro')
SubProfile-->>Chat: subprofile key
Chat->>ConnConfig: get(subprofile).get('apikey')
ConnConfig-->>Chat: api_key or None
alt api_key present
Chat->>Chat: genai.Client(api_key=api_key)
else
Chat->>Chat: raise ValueError("Please enter your Gemini API key.")
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
get_task_token() now checks arguments.token first, then falls back to request.token so older clients and debug command token injection still work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The URL param carries the freshly-minted key for the current task and must not be shadowed by a stale sessionStorage value from a previous task on the same origin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/dropper-ui/src/App.tsx`:
- Around line 71-74: The conditional is redundant: when token is set from
urlParams.get('auth') the search already contains 'auth=', so remove the inner
check and unconditionally call window.history.replaceState({}, '',
window.location.pathname) inside the if (token) block (referencing token,
urlParams.get('auth') and window.history.replaceState in App.tsx) to match the
chat-ui behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5a8b167d-b09f-43b4-9e49-8d53d5913bba
📒 Files selected for processing (2)
apps/chat-ui/src/App.tsxapps/dropper-ui/src/App.tsx
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resolves conflicts in llm_vision_{gemini,openai}/IInstance.py from upstream
rocketride-org#902 (migrate vision nodes to LLMBase). Both sides add the same
`from ai.common.llm_base import LLMBase` import; kept the existing
HEAD position adjacent to the other ai.common imports and dropped the
duplicate inserted by upstream. Circuit-breaker behavior (CircuitBreakerOpenError
handling + _mark_current_object_retry calls) preserved.
…ision nodes to LLMBase (rocketride-org#902) * fix(nodes): remove llm_vertex, fix llm_gemini key handling, migrate vision nodes to LLMBase - Remove deprecated llm_vertex node (Vertex AI now supported via llm_gemini) - Fix llm_gemini API key validation: drop strict startsWith('AI') check, add sub-key fallback for old pipe files where sub-key is profile.split('_',1)[1] - Fix llm_gemini validateConfig to early-return when apikey is empty (secure fields are not decrypted at validate time) - Migrate llm_vision_gemini and llm_vision_openai IInstance from deprecated IInstanceGenericLLM to ai.common.llm_base.LLMBase - Remove startsWith('AI') key format check from gemini_vision.py - Remove vertex icon from UI icon map and asset bundle - Hide modelSource field in services.common.llm.json (was readonly) - Bump client-typescript SDK version to 1.1.0 - Update test mocks to remove langchain_google_vertexai mock Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(task): add backward-compat fallback for token in DAP request root get_task_token() now checks arguments.token first, then falls back to request.token so older clients and debug command token injection still work. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ui): prioritize URL auth param over sessionStorage token The URL param carries the freshly-minted key for the current task and must not be shadowed by a stale sessionStorage value from a previous task on the same origin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(ui): remove redundant auth check in dropper-ui to match chat-ui Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Rod.Christensen <rod.christensen@rocketride.ai>
Summary
llm_vertexnode — Vertex AI is now supported directly throughllm_gemini(viagenai.Client(vertexai=True, ...)); the separate node is deprecated and deleted along with its icon, mock, and UI referencesllm_geminiAPI key handling — drop the strictstartsWith('AI')format check (rejects valid keys), add sub-key fallback for old pipe files where the stored sub-key isprofile.split('_', 1)[1]instead of the full profile name; also early-return invalidateConfigwhenapikeyis empty (secure fields aren't decrypted at validate time)LLMBase—llm_vision_geminiandllm_vision_openaiIInstancenow inherit fromai.common.llm_base.LLMBaseinstead of the deprecatednodes.llm_base.IInstanceGenericLLM; also remove the redundantstartsWith('AI')key check fromgemini_vision.pymodelSourcefield (was readonly), remove vertex icon asset and map entry, bump client-typescript SDK to1.1.0, update test mocksTest plan
llm_geminiin the chat chain and confirm it initializes and respondsllm_vision_geminiand confirm image description still worksllm_vision_openaiand confirm image description still worksllm_vertexremain in the UI node pickergemini-2_5-flashmock test case)🤖 Generated with Claude Code
Summary by CodeRabbit
Removed Features
Improvements
authparameter now takes priority for auth tokensUpdates