Skip to content

feat(vscode): show pipeline errors and warnings on status view and sidebar - #60

Closed
asclearuc wants to merge 2 commits into
developfrom
feat/error-warn-status
Closed

asclearuc wants to merge 2 commits into
developfrom
feat/error-warn-status

Conversation

@asclearuc

Copy link
Copy Markdown
Collaborator

Summary

  • Surface engine errors and warnings on the pipeline status screen (same view as the Run button and charts) and keep them visible after the pipeline ends.
  • Red/yellow exclamation indicators next to Run and in the pipelines tree; Errors and Warnings tree entries with scroll-to-section.
  • Per-section clear: clearErrorsForTask / clearWarningsForTask; "Mark as read" clears that section. clearErrorsWarningsForTask clears both when starting a new run (Run/Restart, sidebar Run/Launch).
  • Preserve last known errors/warnings when the server sends an empty "not running" status so the red "!" and messages stay visible after the run ends.
  • Read state for errors/warnings; shared types and styles; package.json and extension exports; launch and depends updates as needed.

Images for pipeline execution that finishes with warnings (similar for the errors):
image
image
image

Type

Testing

  • Tests added or updated
  • Tested locally
  • ./builder test passes

Checklist

  • Commit messages follow conventional commits
  • No secrets or credentials included
  • Wiki updated (if applicable)
  • Breaking changes documented (if applicable)

Related Issues

…debar

- Surface engine errors and warnings on the pipeline status screen (same
  view as the Run button and charts) and keep them visible after the
  pipeline ends.
- Red/yellow exclamation indicators next to Run and in the pipelines
  tree; Errors and Warnings tree entries with scroll-to-section.
- Per-section clear: clearErrorsForTask / clearWarningsForTask; "Mark as
  read" clears that section. clearErrorsWarningsForTask clears both when
  starting a new run (Run/Restart, sidebar Run/Launch).
- Preserve last known errors/warnings when the server sends an empty
  "not running" status so the red "!" and messages stay visible after
  the run ends.
- Read state for errors/warnings; shared types and styles; package.json
  and extension exports; launch and depends updates as needed.

@Rod-Christensen Rod-Christensen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really do like this --- it was a good solution to a big problem. Can you change the yellow ! to be a button, or at least, the same size as the Run button?

@Rod-Christensen

Copy link
Copy Markdown
Collaborator

Hi Alexandru,

I reworked the PageStatus a bit so I don't think this PR is necessary any more...

image

@Rod-Christensen

Copy link
Copy Markdown
Collaborator

It was just getting too busy and unusable so I added a tab strip across the top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants