Repository navigation
feat(nodes): add data format converter node for JSON/CSV/XML conversion - #566
charliegillet wants to merge 1 commit into
Conversation
…screen Handle TASK_STATE.STOPPING in the control button to show "Stopping..." with a disabled state and distinct orange styling, preventing duplicate clicks and giving immediate visual feedback during pipeline shutdown. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe changes add explicit handling for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/vscode/src/providers/views/PageStatus/PageStatus.tsx (1)
353-363:⚠️ Potential issue | 🟠 MajorHandle
TASK_STATE.STARTINGexplicitly ingetControlButton().Line 362 currently catches
STARTINGin the default branch, which renders a disabled Run button during startup. This leaves the control state inconsistent with an active startup phase.Proposed fix
- if (state === TASK_STATE.RUNNING || state === TASK_STATE.INITIALIZING) { + if (state === TASK_STATE.RUNNING || state === TASK_STATE.INITIALIZING || state === TASK_STATE.STARTING) { return { label: 'Stop', action: 'stop' as const, disabled: false, className: 'action-btn stop-btn' }; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/vscode/src/providers/views/PageStatus/PageStatus.tsx` around lines 353 - 363, Add an explicit branch in getControlButton to handle TASK_STATE.STARTING instead of falling through to the default disabled Run button; update getControlButton to return something like { label: 'Starting...', action: 'stop' as const, disabled: false, className: 'action-btn stop-btn' } for TASK_STATE.STARTING so the UI reflects an active startup and allows stopping (refer to the getControlButton function and TASK_STATE enum).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@apps/vscode/src/providers/views/PageStatus/PageStatus.tsx`:
- Around line 353-363: Add an explicit branch in getControlButton to handle
TASK_STATE.STARTING instead of falling through to the default disabled Run
button; update getControlButton to return something like { label: 'Starting...',
action: 'stop' as const, disabled: false, className: 'action-btn stop-btn' } for
TASK_STATE.STARTING so the UI reflects an active startup and allows stopping
(refer to the getControlButton function and TASK_STATE enum).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: e59aa987-d61e-4ffb-8102-daf9efada388
📒 Files selected for processing (2)
apps/vscode/src/providers/views/PageStatus/PageStatus.tsxapps/vscode/src/providers/views/PageStatus/styles.css
|
Closing — the data format converter node code was not committed to this branch. Will resubmit if needed. |
Top-level `permissions: { contents: write, packages: write, id-token: write }`
on nightly.yaml granted every job in the workflow the union of all writes
any one job needed, including jobs that only consume read-only inputs. The
Scorecard `TokenPermissionsID` rule flags this as the most severe form of
over-grant because top-level writes propagate to every reuse-called
workflow as the upper bound.
Drop the top-level to `contents: read` and raise per-job only where the
job actually writes:
- build: contents: read, packages: write
(forwarded to _build.yaml for NuGet/vcpkg writes
to ghcr.io via VCPKG_BINARY_SOURCES=...readwrite)
- cleanup-prereleases: contents: write
(git push origin --delete <tag> and gh release
delete; the tag deletion requires repo write)
- prerelease: contents: write, id-token: write
(forwarded to _release.yaml for tag push +
gh release create + Sigstore keyless signing)
- docker: contents: read, packages: write
(forwarded to _docker.yaml for ghcr image push;
matches release.yaml's docker job pattern)
- init: no override, inherits top-level read
(_init.yaml is read-only — extracts versions
from package.json via jq and stamps github.sha)
The grants mirror the canonical pattern already in place in release.yaml
(committed in the prior TokenPermissionsID cleanup pass that closed #513
and #515 on _build.yaml and _init.yaml).
Closes Scorecard TokenPermissionsID alerts #566 (topLevel contents:write)
and #567 (topLevel packages:write).
The remaining 10 TokenPermissionsID alerts on this repo (#451, #452, #454,
#455, #489, #490, #604, #635, #649, #650) flag job-level writes that are
required for the job's function (ghcr image push, GitHub release publish,
artifact cleanup, model-sync commits). Those are being dismissed
separately with "won't fix" + per-alert justification — Scorecard
penalizes any write, including the unavoidable kind.
…1967) Closes Scorecard PinnedDependenciesID alert #671: the checkout step at line 81 used the floating tag actions/checkout@v4. Pinned to the same SHA the rest of the workflows in this repo use (34e114876b0b11c390a56381ad16ebd13914f8d5, v4.x), with a version comment so future readers see the intended v4 line without decoding the SHA. The other four PinnedDependenciesID alerts in this repo (npmCommand in n8n-nodes-ci.yml and n8n-nodes-release.yml, pipCommand in os-matrix.yml) are not safe drop-in code fixes and are being dismissed as won't fix with rationale on the alerts themselves: - npm commands: npm binary is already version-pinned to 11.19.0, and the subsequent npm ci reads from packages/n8n-nodes/package-lock.json where every dependency IS hash-pinned. Scorecard's rule cannot see through the two-step bootstrap. - pip commands: os-matrix.yml lines 103-104 install build+wheel with intentionally unversioned specs. The file comment above the command explains why (on Ubuntu 24.04+ wheel is distro-managed and pinning a specific version breaks the pip bootstrap; a plain install skips the already-satisfied wheel). The 16 TokenPermissionsID alerts in this repo are also being dismissed as won't fix: they all point at job-level packages:write, contents:write, or actions:write scopes on release, prerelease, experimental-release, release-backmerge, storage-cleanup, and sync-models workflows, where the write scope is the minimum required for the job's purpose. Workflow-level defaults are already contents:read (already addressing Scorecard alerts #513, #516, #566, #567, #605 per in-file comments).
…ocketride-org#1967) Closes Scorecard PinnedDependenciesID alert rocketride-org#671: the checkout step at line 81 used the floating tag actions/checkout@v4. Pinned to the same SHA the rest of the workflows in this repo use (34e114876b0b11c390a56381ad16ebd13914f8d5, v4.x), with a version comment so future readers see the intended v4 line without decoding the SHA. The other four PinnedDependenciesID alerts in this repo (npmCommand in n8n-nodes-ci.yml and n8n-nodes-release.yml, pipCommand in os-matrix.yml) are not safe drop-in code fixes and are being dismissed as won't fix with rationale on the alerts themselves: - npm commands: npm binary is already version-pinned to 11.19.0, and the subsequent npm ci reads from packages/n8n-nodes/package-lock.json where every dependency IS hash-pinned. Scorecard's rule cannot see through the two-step bootstrap. - pip commands: os-matrix.yml lines 103-104 install build+wheel with intentionally unversioned specs. The file comment above the command explains why (on Ubuntu 24.04+ wheel is distro-managed and pinning a specific version breaks the pip bootstrap; a plain install skips the already-satisfied wheel). The 16 TokenPermissionsID alerts in this repo are also being dismissed as won't fix: they all point at job-level packages:write, contents:write, or actions:write scopes on release, prerelease, experimental-release, release-backmerge, storage-cleanup, and sync-models workflows, where the write scope is the minimum required for the job's purpose. Workflow-level defaults are already contents:read (already addressing Scorecard alerts rocketride-org#513, rocketride-org#516, rocketride-org#566, rocketride-org#567, rocketride-org#605 per in-file comments).
…-org#929) Top-level `permissions: { contents: write, packages: write, id-token: write }` on nightly.yaml granted every job in the workflow the union of all writes any one job needed, including jobs that only consume read-only inputs. The Scorecard `TokenPermissionsID` rule flags this as the most severe form of over-grant because top-level writes propagate to every reuse-called workflow as the upper bound. Drop the top-level to `contents: read` and raise per-job only where the job actually writes: - build: contents: read, packages: write (forwarded to _build.yaml for NuGet/vcpkg writes to ghcr.io via VCPKG_BINARY_SOURCES=...readwrite) - cleanup-prereleases: contents: write (git push origin --delete <tag> and gh release delete; the tag deletion requires repo write) - prerelease: contents: write, id-token: write (forwarded to _release.yaml for tag push + gh release create + Sigstore keyless signing) - docker: contents: read, packages: write (forwarded to _docker.yaml for ghcr image push; matches release.yaml's docker job pattern) - init: no override, inherits top-level read (_init.yaml is read-only — extracts versions from package.json via jq and stamps github.sha) The grants mirror the canonical pattern already in place in release.yaml (committed in the prior TokenPermissionsID cleanup pass that closed rocketride-org#513 and rocketride-org#515 on _build.yaml and _init.yaml). Closes Scorecard TokenPermissionsID alerts rocketride-org#566 (topLevel contents:write) and rocketride-org#567 (topLevel packages:write). The remaining 10 TokenPermissionsID alerts on this repo (rocketride-org#451, rocketride-org#452, rocketride-org#454, rocketride-org#455, rocketride-org#489, rocketride-org#490, rocketride-org#604, rocketride-org#635, rocketride-org#649, rocketride-org#650) flag job-level writes that are required for the job's function (ghcr image push, GitHub release publish, artifact cleanup, model-sync commits). Those are being dismissed separately with "won't fix" + per-alert justification — Scorecard penalizes any write, including the unavoidable kind.
…ocketride-org#1967) Closes Scorecard PinnedDependenciesID alert rocketride-org#671: the checkout step at line 81 used the floating tag actions/checkout@v4. Pinned to the same SHA the rest of the workflows in this repo use (34e114876b0b11c390a56381ad16ebd13914f8d5, v4.x), with a version comment so future readers see the intended v4 line without decoding the SHA. The other four PinnedDependenciesID alerts in this repo (npmCommand in n8n-nodes-ci.yml and n8n-nodes-release.yml, pipCommand in os-matrix.yml) are not safe drop-in code fixes and are being dismissed as won't fix with rationale on the alerts themselves: - npm commands: npm binary is already version-pinned to 11.19.0, and the subsequent npm ci reads from packages/n8n-nodes/package-lock.json where every dependency IS hash-pinned. Scorecard's rule cannot see through the two-step bootstrap. - pip commands: os-matrix.yml lines 103-104 install build+wheel with intentionally unversioned specs. The file comment above the command explains why (on Ubuntu 24.04+ wheel is distro-managed and pinning a specific version breaks the pip bootstrap; a plain install skips the already-satisfied wheel). The 16 TokenPermissionsID alerts in this repo are also being dismissed as won't fix: they all point at job-level packages:write, contents:write, or actions:write scopes on release, prerelease, experimental-release, release-backmerge, storage-cleanup, and sync-models workflows, where the write scope is the minimum required for the job's purpose. Workflow-level defaults are already contents:read (already addressing Scorecard alerts rocketride-org#513, rocketride-org#516, rocketride-org#566, rocketride-org#567, rocketride-org#605 per in-file comments).
Summary
Type
Feature
How it works
The node sits in a pipeline as a filter. When documents flow through:
Testing
ruff checkandruff formatpass cleanlyRelated Issues
N/A
#Hack-with-bay-2
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Style