Repository navigation
feat(vscode): UX improvements for welcome, settings, pipelines, and U… - #52
Merged
Merged
Conversation
…RI handling
Consolidate URI normalization into client libraries
- Add public static `normalizeUri()` to both TypeScript and Python clients so
all consumers (VS Code extension, CLI, future integrations) share one
implementation. Bare hostnames like "localhost" are prepended with http://
and assigned the default port 5565. This eliminates "Invalid URL format"
errors that occurred when users entered short-form addresses in the Welcome
or Settings pages.
- Internal websocket URI helpers (`_getWebsocketUri` / `_get_websocket_uri`)
now call `normalizeUri` internally instead of duplicating the logic.
- VS Code config validation, HTTP URL, and WebSocket URL derivation all
delegate to `RocketRideClient.normalizeUri()` instead of inline regexes.
- Connection Manager sidebar displays the normalized URI so users see the
actual resolved address (with protocol and port).
Improve pipeline file creation UX
- Replace `showInputBox` with `showSaveDialog` for creating new pipeline
files. This gives native OS file-picker behavior with built-in duplicate
handling, directory navigation, and extension enforcement — eliminating
bugs where files were created without extensions or overwrote existing
files silently.
- Default directory is derived from the user's configured `defaultPipelinePath`
setting, with `${workspaceFolder}` prefix properly stripped.
- New files open directly in the custom pipeline editor via
`vscode.openWith` instead of falling through to the JSON text editor.
Change default pipeline extension from .pipe.json to .pipe
- The compound `.pipe.json` extension caused the Windows Save dialog to
display `.pipe` in the filename field, leading to double-extension files
like `name.pipe.pipe.json`. The new `.pipe` extension avoids this.
- Both `*.pipe` and `*.pipe.json` are registered in the custom editor
selector and file watchers so existing pipelines continue to work.
- `configurationDefaults` registers `*.pipe` as JSON so VS Code provides
syntax highlighting and formatting when opened with the text editor.
- Debugger session validation accepts both extensions.
- Tab titles strip both `.pipe` and `.pipe.json` suffixes.
- Documentation and UI text updated to reference `.pipe`.
Add theme-aware logo support
- Replace the single `rocketride-icon.png` with dark and light variants
(`rocketride-dark-icon.png`, `rocketride-light-icon.png`). Remove the
unused SVG icon.
- Deploy page switches logos via CSS classes keyed to VS Code's
`body.vscode-dark` / `body.vscode-light` theme classes.
- Welcome page always uses the light logo since its left panel has a fixed
dark background regardless of theme.
- Activity bar icon uses the light variant (string, not object) because
`viewsContainers.activitybar[].icon` only accepts a string path.
- Deploy command icon uses `{ dark, light }` object format which is
supported on `commands` contributions.
- Build script updated to copy both icon files and set correct `pkg.icon`.
Add Welcome page
- New branded two-column welcome/setup page shown on first install. Left
panel displays logo, feature list, and documentation/support links. Right
panel provides connection mode selector (cloud/on-prem/local), API key
input, engine version picker, and save & connect workflow.
- Auto-opens until dismissed; dismissal persists via globalState so users
see it only once per installation.
- Documentation and Support links use message-passing to open external URLs
via `vscode.env.openExternal` since webview `<a target="_blank">` links
are blocked by VS Code's security model.
- Logo renders without border-radius to preserve the icon's original shape.
Make Settings and Welcome pages singletons
- Settings page now tracks its panel and calls `reveal()` if already open,
matching the Welcome page's existing behavior. Previously, every
"Open Settings" command created a new duplicate tab.
Open Documentation in browser
- The Documentation button in the Connection Manager sidebar now opens
https://docs.rocketride.ai in the default browser via
`vscode.env.openExternal` instead of previewing a bundled markdown file.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Overhaul the canvas node visual styling to provide a clean, theme-aware appearance inside VS Code webviews while preserving standalone web styling. Border & shape: - Add reactflow-overrides.css to enforce a single authoritative border (1px solid widget-border) and 4px border-radius on all node containers, eliminating double-border artifacts from competing style sources - Remove all internal borders, outlines, and box-shadows from flowRoot, headerWrapper, and annotation nodes in VS Code mode - Use corner cap elements (4px spacers with matching backgrounds and border-radius) at top/bottom of node content to fill rounded corners without overflow:hidden, which would clip handles and the run button Layout restructuring: - Move RunButton outside nodeContent using a React fragment so it is not clipped by the node container - Add 1px border-top separator on lanes section using VS Code widget border - Reduce header top padding to compensate for the corner cap spacer - Reduce icon min-width from 1.95rem to 1rem for tighter node headers Handle redesign: - Change connection handles from circles (8px, borderRadius 8px) to rounded boxes (12px, borderRadius 2px) for a modern appearance - Increase lane label horizontal padding to 0.6rem for handle spacing Annotation nodes: - Make annotation node borders fully transparent so they remain in the ReactFlow layout without visible outlines or shadows Brand color replacement: - Replace all brandOrange references with var(--vscode-button-background) in VS Code mode across: selection outlines, resize controls, handle colors, run button hover, add-node button icon, and floating group button — falling back to brandOrange in standalone mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move invoke handle rendering from Lanes.tsx to Node.tsx so the diamond handles sit on the actual top/bottom edges of the node rather than floating inside the lanes area. Previously the bottom invoke handle appeared detached from the node border because it was rendered inside Lanes, which is followed by the footer and bottom cap elements. Placing the handles as absolute-positioned siblings of the nodeContent box — anchored to top:0/bottom:0 with translateY(±50%) — centers them on the node border and avoids the NaN SVG path errors that occurred when wrapping handles in positioned containers inside Lanes. Additional changes: - Restyle InvokeHandle to match data handles: larger hit area (14px), 12px diamond with rounded corners, VS Code theme-aware colors for selected/connected/default states, remove text label - Render invoke edges as dotted lines (strokeDasharray 2,4 with round linecap) to visually distinguish invocation flow from data flow - Add overflow:visible to flowRoot so handles can extend beyond the node boundary without clipping - Fix InsideLines not rendering on initial load by replacing useRef with a callback ref + useState pattern, since ref assignments don't trigger re-renders Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…add subheader to nodes
ryan-t-christensen
previously approved these changes
Feb 27, 2026
…rovements, resolve conflicts
ryan-t-christensen
approved these changes
Feb 27, 2026
3 tasks
AviNormie
pushed a commit
to AviNormie/rocketride-server
that referenced
this pull request
Nov 9, 2026
rocketride-org#52) * feat(vscode): UX improvements for welcome, settings, pipelines, and URI handling Consolidate URI normalization into client libraries - Add public static `normalizeUri()` to both TypeScript and Python clients so all consumers (VS Code extension, CLI, future integrations) share one implementation. Bare hostnames like "localhost" are prepended with http:// and assigned the default port 5565. This eliminates "Invalid URL format" errors that occurred when users entered short-form addresses in the Welcome or Settings pages. - Internal websocket URI helpers (`_getWebsocketUri` / `_get_websocket_uri`) now call `normalizeUri` internally instead of duplicating the logic. - VS Code config validation, HTTP URL, and WebSocket URL derivation all delegate to `RocketRideClient.normalizeUri()` instead of inline regexes. - Connection Manager sidebar displays the normalized URI so users see the actual resolved address (with protocol and port). Improve pipeline file creation UX - Replace `showInputBox` with `showSaveDialog` for creating new pipeline files. This gives native OS file-picker behavior with built-in duplicate handling, directory navigation, and extension enforcement — eliminating bugs where files were created without extensions or overwrote existing files silently. - Default directory is derived from the user's configured `defaultPipelinePath` setting, with `${workspaceFolder}` prefix properly stripped. - New files open directly in the custom pipeline editor via `vscode.openWith` instead of falling through to the JSON text editor. Change default pipeline extension from .pipe.json to .pipe - The compound `.pipe.json` extension caused the Windows Save dialog to display `.pipe` in the filename field, leading to double-extension files like `name.pipe.pipe.json`. The new `.pipe` extension avoids this. - Both `*.pipe` and `*.pipe.json` are registered in the custom editor selector and file watchers so existing pipelines continue to work. - `configurationDefaults` registers `*.pipe` as JSON so VS Code provides syntax highlighting and formatting when opened with the text editor. - Debugger session validation accepts both extensions. - Tab titles strip both `.pipe` and `.pipe.json` suffixes. - Documentation and UI text updated to reference `.pipe`. Add theme-aware logo support - Replace the single `rocketride-icon.png` with dark and light variants (`rocketride-dark-icon.png`, `rocketride-light-icon.png`). Remove the unused SVG icon. - Deploy page switches logos via CSS classes keyed to VS Code's `body.vscode-dark` / `body.vscode-light` theme classes. - Welcome page always uses the light logo since its left panel has a fixed dark background regardless of theme. - Activity bar icon uses the light variant (string, not object) because `viewsContainers.activitybar[].icon` only accepts a string path. - Deploy command icon uses `{ dark, light }` object format which is supported on `commands` contributions. - Build script updated to copy both icon files and set correct `pkg.icon`. Add Welcome page - New branded two-column welcome/setup page shown on first install. Left panel displays logo, feature list, and documentation/support links. Right panel provides connection mode selector (cloud/on-prem/local), API key input, engine version picker, and save & connect workflow. - Auto-opens until dismissed; dismissal persists via globalState so users see it only once per installation. - Documentation and Support links use message-passing to open external URLs via `vscode.env.openExternal` since webview `<a target="_blank">` links are blocked by VS Code's security model. - Logo renders without border-radius to preserve the icon's original shape. Make Settings and Welcome pages singletons - Settings page now tracks its panel and calls `reveal()` if already open, matching the Welcome page's existing behavior. Previously, every "Open Settings" command created a new duplicate tab. Open Documentation in browser - The Documentation button in the Connection Manager sidebar now opens https://docs.rocketride.ai in the default browser via `vscode.env.openExternal` instead of previewing a bundled markdown file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat(canvas): redesign node styling for VS Code theme consistency Overhaul the canvas node visual styling to provide a clean, theme-aware appearance inside VS Code webviews while preserving standalone web styling. Border & shape: - Add reactflow-overrides.css to enforce a single authoritative border (1px solid widget-border) and 4px border-radius on all node containers, eliminating double-border artifacts from competing style sources - Remove all internal borders, outlines, and box-shadows from flowRoot, headerWrapper, and annotation nodes in VS Code mode - Use corner cap elements (4px spacers with matching backgrounds and border-radius) at top/bottom of node content to fill rounded corners without overflow:hidden, which would clip handles and the run button Layout restructuring: - Move RunButton outside nodeContent using a React fragment so it is not clipped by the node container - Add 1px border-top separator on lanes section using VS Code widget border - Reduce header top padding to compensate for the corner cap spacer - Reduce icon min-width from 1.95rem to 1rem for tighter node headers Handle redesign: - Change connection handles from circles (8px, borderRadius 8px) to rounded boxes (12px, borderRadius 2px) for a modern appearance - Increase lane label horizontal padding to 0.6rem for handle spacing Annotation nodes: - Make annotation node borders fully transparent so they remain in the ReactFlow layout without visible outlines or shadows Brand color replacement: - Replace all brandOrange references with var(--vscode-button-background) in VS Code mode across: selection outlines, resize controls, handle colors, run button hover, add-node button icon, and floating group button — falling back to brandOrange in standalone mode Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * feat(canvas): restyle invoke handles and move to node border caps Move invoke handle rendering from Lanes.tsx to Node.tsx so the diamond handles sit on the actual top/bottom edges of the node rather than floating inside the lanes area. Previously the bottom invoke handle appeared detached from the node border because it was rendered inside Lanes, which is followed by the footer and bottom cap elements. Placing the handles as absolute-positioned siblings of the nodeContent box — anchored to top:0/bottom:0 with translateY(±50%) — centers them on the node border and avoids the NaN SVG path errors that occurred when wrapping handles in positioned containers inside Lanes. Additional changes: - Restyle InvokeHandle to match data handles: larger hit area (14px), 12px diamond with rounded corners, VS Code theme-aware colors for selected/connected/default states, remove text label - Render invoke edges as dotted lines (strokeDasharray 2,4 with round linecap) to visually distinguish invocation flow from data flow - Add overflow:visible to flowRoot so handles can extend beyond the node boundary without clipping - Fix InsideLines not rendering on initial load by replacing useRef with a callback ref + useState pattern, since ref assignments don't trigger re-renders Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove prefixes for node titles, ensure anthropic svg matches theme, add subheader to nodes * Fix inside lines component * change color of save button in node config to match vs code theme * resolve conflicts, update with develop --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: ryan-t-christensen <ryan.christensen@rocketride.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX improvements for welcome, settings, pipelines, and URI handling
Consolidate URI normalization into client libraries
normalizeUri()to both TypeScript and Python clients so all consumers (VS Code extension, CLI, future integrations) share one implementation. Bare hostnames like "localhost" are prepended with http:// and assigned the default port 5565. This eliminates "Invalid URL format" errors that occurred when users entered short-form addresses in the Welcome or Settings pages._getWebsocketUri/_get_websocket_uri) now callnormalizeUriinternally instead of duplicating the logic.RocketRideClient.normalizeUri()instead of inline regexes.Improve pipeline file creation UX
showInputBoxwithshowSaveDialogfor creating new pipeline files. This gives native OS file-picker behavior with built-in duplicate handling, directory navigation, and extension enforcement — eliminating bugs where files were created without extensions or overwrote existing files silently.defaultPipelinePathsetting, with${workspaceFolder}prefix properly stripped.vscode.openWithinstead of falling through to the JSON text editor.Change default pipeline extension from .pipe.json to .pipe
.pipe.jsonextension caused the Windows Save dialog to display.pipein the filename field, leading to double-extension files likename.pipe.pipe.json. The new.pipeextension avoids this.*.pipeand*.pipe.jsonare registered in the custom editor selector and file watchers so existing pipelines continue to work.configurationDefaultsregisters*.pipeas JSON so VS Code provides syntax highlighting and formatting when opened with the text editor..pipeand.pipe.jsonsuffixes..pipe.Add theme-aware logo support
rocketride-icon.pngwith dark and light variants (rocketride-dark-icon.png,rocketride-light-icon.png). Remove the unused SVG icon.body.vscode-dark/body.vscode-lighttheme classes.viewsContainers.activitybar[].icononly accepts a string path.{ dark, light }object format which is supported oncommandscontributions.pkg.icon.Add Welcome page
vscode.env.openExternalsince webview<a target="_blank">links are blocked by VS Code's security model.Make Settings and Welcome pages singletons
reveal()if already open, matching the Welcome page's existing behavior. Previously, every "Open Settings" command created a new duplicate tab.Open Documentation in browser
vscode.env.openExternalinstead of previewing a bundled markdown file.