You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs(tool_tenki): link #3411 from the after-cutoff TODO - #3413
The should-fix from the #3412 review, kept out of #3412 so its approval stands. Stacked on fix/tool-tenki-luxor-review-followups; GitHub moves the base to develop when #3412 merges.
The TODO at _retired_names now reads TODO(#3411), so it links the tracking issue for the after-cutoff cleanup.
Comment-only change; ruff clean.
Summary by CodeRabbit
Documentation
Updated a note about legacy tk_ handling and dated warnings, and clarified that the Tenki API URL change remains in place for saved pipelines.
No actionable comments were generated in the recent review.
Walkthrough
The Tenki compatibility TODO now sets a removal date after 2027-01-01 and states that the api.tenki.cloud URL swap should remain for saved pipelines.
Changes: Tenki Compatibility TODO
Layer / File(s)
Summary
Post-cutoff compatibility TODO nodes/src/nodes/tool_tenki/IGlobal.py
The TODO dates removal of tk_ handling and dated warnings to after 2027-01-01. It also says to retain the api.tenki.cloud URL swap for saved pipelines.
This is a comment-only update that documents when the Tenki compatibility handling can be removed. It has no runtime impact and is safe to merge.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the docs type and the tool_tenki scope, and it says the change links #3411 from the after-cutoff TODO. The raw summary and objectives describe a comment-only change in nodes/src/nodes/…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the docs type and the tool_tenki scope, and it says the change links #3411 from the after-cutoff TODO. The raw summary and objectives describe a comment-only change in nodes/src/nodes/tool_tenki/IGlobal.py that changes the TODO to reference #3411 and dates the cleanup after 2027-01-01. The title does not mention the date-based wording, but it identifies the actual change, so it is related to the main change.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 11b4297 and 1021de3.
Files selected for processing: 1
nodes/src/nodes/tool_tenki/IGlobal.py
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The should-fix from the #3412 review, kept out of #3412 so its approval stands. Stacked on
fix/tool-tenki-luxor-review-followups; GitHub moves the base todevelopwhen #3412 merges._retired_namesnow readsTODO(#3411), so it links the tracking issue for the after-cutoff cleanup.Comment-only change; ruff clean.
Summary by CodeRabbit
tk_handling and dated warnings, and clarified that the Tenki API URL change remains in place for saved pipelines.