Skip to content

docs(tool_tenki): link #3411 from the after-cutoff TODO - #3413

Open
2001anshkaushik wants to merge 1 commit into
developfrom
fix/tool-tenki-todo-issue-link
Open

2001anshkaushik wants to merge 1 commit into
developfrom
fix/tool-tenki-todo-issue-link

Conversation

@2001anshkaushik

@2001anshkaushik 2001anshkaushik commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

The should-fix from the #3412 review, kept out of #3412 so its approval stands. Stacked on fix/tool-tenki-luxor-review-followups; GitHub moves the base to develop when #3412 merges.

  • The TODO at _retired_names now reads TODO(#3411), so it links the tracking issue for the after-cutoff cleanup.

Comment-only change; ruff clean.

Summary by CodeRabbit

  • Documentation
    • Updated a note about legacy tk_ handling and dated warnings, and clarified that the Tenki API URL change remains in place for saved pipelines.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Tenki compatibility TODO now sets a removal date after 2027-01-01 and states that the api.tenki.cloud URL swap should remain for saved pipelines.

Changes: Tenki Compatibility TODO

Layer / File(s) Summary
Post-cutoff compatibility TODO
nodes/src/nodes/tool_tenki/IGlobal.py
The TODO dates removal of tk_ handling and dated warnings to after 2027-01-01. It also says to retain the api.tenki.cloud URL swap for saved pipelines.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related issues

  • Issue 3411 tracks post-cutoff cleanup of the _retired_names path. This TODO update specifies when to remove the related handling and warnings.

Possibly related PRs

Merge Risk: Minimal · up to 1021d

This is a comment-only update that documents when the Tenki compatibility handling can be removed. It has no runtime impact and is safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the docs type and the tool_tenki scope, and it says the change links #3411 from the after-cutoff TODO. The raw summary and objectives describe a comment-only change in nodes/src/nodes/…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the docs type and the tool_tenki scope, and it says the change links #3411 from the after-cutoff TODO. The raw summary and objectives describe a comment-only change in nodes/src/nodes/tool_tenki/IGlobal.py that changes the TODO to reference #3411 and dates the cleanup after 2027-01-01. The title does not mention the date-based wording, but it identifies the actual change, so it is related to the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 11b4297 and 1021de3.

Files selected for processing: 1

  • nodes/src/nodes/tool_tenki/IGlobal.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@github-actions github-actions Bot added the module:nodes Python pipeline nodes label Nov 21, 2026
Base automatically changed from fix/tool-tenki-luxor-review-followups to develop November 21, 2026 01:01
@github-actions github-actions Bot added docs Documentation tests labels Nov 21, 2026
@2001anshkaushik
2001anshkaushik force-pushed the fix/tool-tenki-todo-issue-link branch from 11b4297 to 1021de3 Compare November 21, 2026 01:36
@2001anshkaushik
2001anshkaushik enabled auto-merge (squash) November 21, 2026 01:36
@github-actions github-actions Bot removed docs Documentation tests labels Nov 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:nodes Python pipeline nodes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant