Repository navigation
feat(shell): carry a cookieless signup context through the OAuth state (#2948 to stage) - #2993
Merged
Merged
Conversation
…e (stage version of #2948) The change approved in #2948, applied to stage without develop's #2625: the version reviewed before develop was merged in, plus the later review fixes that apply here (hasPrivacySignal, the identity provider error return stripping its state, CHANGELOG entries). Undecided visitors only: the shell carries the context as a { v: 1, signup } OAuth state envelope, nothing in site storage, and drops it once the visitor accepts or rejects, or sends DNT/GPC. consent_version stays 1; consent_state marks the context.
2001anshkaushik
requested review from
Rod-Christensen,
jmaionchi and
stepmikhaylov
as code owners
November 4, 2026 02:00
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 2
Please check the settings in the CodeRabbit UI or the
|
Contributor
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
dylan-savage
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage version of #2948 (approved), so an undecided visitor's homepage headline can ride their sign-up in tomorrow's release.
Why it isn't byte-identical: #2948 on develop was merged with develop's #2625 (the shell bus rework), which isn't on stage and isn't part of this release. This branch is #2948 as reviewed before that merge, applied to
stagewithout conflicts, plus the later review fixes that apply here.Same as #2948
{ v: 1, signup }OAuth state envelope, with nothing in site storage.consent_versionstays 1 andconsent_statemarks the context.hasPrivacySignal.Different, because stage differs
statefix: the duplicate only appeared in the App Builder in the cloud: unified shell bus, devtool platform, local-first dev previews #2625 merge.Checks on this branch
shell:check"Up to date with v8 (no actionable change)".signup-wire23/23; eslint clean.roulette-native,roulette) against a shell built from this branch: 216/216 passed in Chromium, Firefox and WebKit, desktop, tablet and mobile.Release: after this merges, the saas
rocketride-serverpin needs bumping to server stage, so undecided visitors' sign-ups carry the headline (rocketride-ai/rocketride-saas#1076).