Skip to content

feat(shell): carry a cookieless signup context through the OAuth state (#2948 to stage) - #2993

Merged
2001anshkaushik merged 1 commit into
stagefrom
fix/signup-attribution-cookieless-stage
Nov 4, 2026
Merged

2001anshkaushik merged 1 commit into
stagefrom
fix/signup-attribution-cookieless-stage

Conversation

@2001anshkaushik

Copy link
Copy Markdown
Collaborator

Stage version of #2948 (approved), so an undecided visitor's homepage headline can ride their sign-up in tomorrow's release.

Why it isn't byte-identical: #2948 on develop was merged with develop's #2625 (the shell bus rework), which isn't on stage and isn't part of this release. This branch is #2948 as reviewed before that merge, applied to stage without conflicts, plus the later review fixes that apply here.

Same as #2948

  • Undecided visitors only, with consent rechecked when the state is built, on the callback and before authentication.
  • The { v: 1, signup } OAuth state envelope, with nothing in site storage.
  • The corrected storage, history and identity-provider-log docs.
  • consent_version stays 1 and consent_state marks the context.
  • hasPrivacySignal.
  • The identity provider error return strips its state.
  • CHANGELOG entries.

Different, because stage differs

Checks on this branch

  • Shell tests 119/119.
  • shell:check "Up to date with v8 (no actionable change)".
  • SDK signup-wire 23/23; eslint clean.
  • The saas Roulette sign-up suites (roulette-native, roulette) against a shell built from this branch: 216/216 passed in Chromium, Firefox and WebKit, desktop, tablet and mobile.

Release: after this merges, the saas rocketride-server pin needs bumping to server stage, so undecided visitors' sign-ups carry the headline (rocketride-ai/rocketride-saas#1076).

…e (stage version of #2948)

The change approved in #2948, applied to stage without develop's #2625: the version reviewed before develop was
merged in, plus the later review fixes that apply here (hasPrivacySignal, the identity provider error return
stripping its state, CHANGELOG entries). Undecided visitors only: the shell carries the context as a { v: 1, signup }
OAuth state envelope, nothing in site storage, and drops it once the visitor accepts or rejects, or sends DNT/GPC.
consent_version stays 1; consent_state marks the context.
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 2
  • develop
  • release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added docs Documentation module:ui Chat UI and Dropper UI module:client-typescript TypeScript client SDK tests labels Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation module:client-typescript TypeScript client SDK module:ui Chat UI and Dropper UI tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants