Repository navigation
fix(agent_rocketride): log the wait for timed-out calls as a warning - #2714
dk-rocketride merged 2 commits into
Conversation
When a tool call times out, the run waits for it to return before it ends (rocketride-org#2521). It logged that wait with rocketlib.error(), which puts it in the task's errors. The canvas shows a node with any error as failed, so a run that handled the timeout and answered normally looked failed. The wait is now a warning. The wait itself is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
…2714 to stage) (#2715) * fix(agent_rocketride): log the wait for timed-out calls as a warning When a tool call times out, the run waits for it to return before it ends (#2521). It logged that wait with rocketlib.error(), which puts it in the task's errors. The canvas shows a node with any error as failed, so a run that handled the timeout and answered normally looked failed. The wait is now a warning. The wait itself is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(agent_rocketride): release the timed-out call from a named function --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
dk-rocketride
left a comment
There was a problem hiding this comment.
Same changed lines as #2715, which has been on stage since 10-20. Merging so today's develop-to-stage cut keeps the fix.
Summary
Split out of #2688 at review. Found while testing the 10/20 release end to end (agent_rocketride on a running stage engine).
rocketlib.error(), which lands intask_status.errors. The canvas shows a node with any error as failed, even though the run answered normally.warning(). The wait itself is unchanged.Type
fix
Testing
./builder testnot run in full; GitHub CI is the repository-wide gateEnd to end, with a scripted mock model behind
llm_openai_api, on an engine atdevelop(before) and one with this change (after):task_status.errorshasError*rocketride wave: waiting for 1 timed-out tool call(s)...errorsempty; the wait is inwarnings["done"], no errorsNew test:
test_wave_timeouts.py::test_waiting_for_a_timed_out_call_is_a_warning_not_an_error.Checklist
Agent context
Claude Opus 5.5 / T3 Code, under explicit approval. Audited first by OpenAI Codex (gpt-6.1-sol, xhigh).
Paired PR
Stage: #2715
Linked Issue
Closes #2707
Related: #2521, #2511.
Summary by CodeRabbit