Skip to content

fix(agent_rocketride): log the wait for timed-out calls as a warning - #2714

Merged
dk-rocketride merged 2 commits into
rocketride-org:developfrom
krishhgg:fix/agent-timeout-wait-warning
Oct 28, 2026
Merged

dk-rocketride merged 2 commits into
rocketride-org:developfrom
krishhgg:fix/agent-timeout-wait-warning

Conversation

@krishhgg

@krishhgg krishhgg commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Split out of #2688 at review. Found while testing the 10/20 release end to end (agent_rocketride on a running stage engine).

  • A handled timeout marked the task as failed. When a tool call times out, the Wave driver answers without it, and before the run ends it waits for the call to return (fix(agent_rocketride): enforce the tool time limit; keep run state per run #2521). It logged that wait with rocketlib.error(), which lands in task_status.errors. The canvas shows a node with any error as failed, even though the run answered normally.
  • The wait is now a warning(). The wait itself is unchanged.

Type

fix

Testing

  • Tests added or updated
  • Tested locally, end to end on a running engine
  • ./builder test not run in full; GitHub CI is the repository-wide gate

End to end, with a scripted mock model behind llm_openai_api, on an engine at develop (before) and one with this change (after):

Run Before After
a call times out (limit 2 s, call sleeps 8 s), the model answers answer returned; task_status.errors has Error*rocketride wave: waiting for 1 timed-out tool call(s)... same answer; errors empty; the wait is in warnings
control: a normal run stop reasons ["done"], no errors unchanged
nodes/test/agent_rocketride/: 234 passed
ruff check + ruff format --check: passed

New test: test_wave_timeouts.py::test_waiting_for_a_timed_out_call_is_a_warning_not_an_error.

Checklist

  • Commit messages follow conventional commits
  • No secrets or credentials included
  • Wiki updated (if applicable): not applicable
  • Breaking changes documented (if applicable): none.

Agent context

Claude Opus 5.5 / T3 Code, under explicit approval. Audited first by OpenAI Codex (gpt-6.1-sol, xhigh).

Paired PR

Stage: #2715

Linked Issue

Closes #2707

Related: #2521, #2511.

Summary by CodeRabbit

  • Bug Fixes
    • Waiting for a tool call that has timed out is now reported as a warning instead of an error. The system continues waiting for the call to finish before cleanup, allowing the workflow to complete successfully without treating the wait as a failure.

krishhgg and others added 2 commits October 19, 2026 20:19
When a tool call times out, the run waits for it to return before it ends
(rocketride-org#2521). It logged that wait with rocketlib.error(), which puts it in the
task's errors. The canvas shows a node with any error as failed, so a run
that handled the timeout and answered normally looked failed.

The wait is now a warning. The wait itself is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: rocketride-org/rocketride-server/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 552c7b49-f2b3-40c5-b3a3-83f2531558c5
📥 Commits

Reviewing files that changed from the base of the PR and between 34dd2ea and 5455b8c.

📒 Files selected for processing: 2
  • nodes/src/nodes/agent_rocketride/rocketride_agent.py
  • nodes/test/agent_rocketride/test_wave_timeouts.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The driver now logs waits for timed-out tool calls as warnings instead of errors. The wait remains in place. A test checks that the run returns its answer and done stop reason without logging an error.

Changes: Timed-out tool call logging

Layer / File(s) Summary
Log and verify the wait warning
nodes/src/nodes/agent_rocketride/rocketride_agent.py, nodes/test/agent_rocketride/test_wave_timeouts.py
The driver logs the wait for timed-out tool calls as a warning and continues waiting. The test checks that the answer is Done., the stop reason is done, no error is logged, and one warning mentions the pending call.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 5455b

This change logs the wait for timed-out tool calls as a warning instead of an error, so a handled timeout no longer makes a normally answered run look failed. No merge-blocking risk was found.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: logging waits for timed-out calls as warnings instead of errors.
Linked Issues check Passed The change satisfies directly linked issue #2707. In rocketride_agent.py, the wait for timed-out tool calls still executes, but the log call changes from error() to warning(). The added test cov…
Out of Scope Changes check Passed The pull request changes only the log level for the timed-out-call wait and adds a focused regression test. Both changes directly support issue #2707. No unrelated implementation or test changes appea…
Docstring Coverage Passed Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.
Full details: Linked Issues check

Explanation

The change satisfies directly linked issue #2707. In rocketride_agent.py, the wait for timed-out tool calls still executes, but the log call changes from error() to warning(). The added test covers a handled timeout and verifies the answer is Done., the stop reason is done, no error is logged, and one warning reports the pending call. This matches the required behavior from #2707 and preserves the cleanup wait required by #2521.

Full details: Out of Scope Changes check

Explanation

The pull request changes only the log level for the timed-out-call wait and adds a focused regression test. Both changes directly support issue #2707. No unrelated implementation or test changes appear in the whole-pull-request diff.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@github-actions github-actions Bot added the module:nodes Python pipeline nodes label Oct 19, 2026
krishhgg added a commit that referenced this pull request Oct 20, 2026
…2714 to stage) (#2715)

* fix(agent_rocketride): log the wait for timed-out calls as a warning

When a tool call times out, the run waits for it to return before it ends
(#2521). It logged that wait with rocketlib.error(), which puts it in the
task's errors. The canvas shows a node with any error as failed, so a run
that handled the timeout and answered normally looked failed.

The wait is now a warning. The wait itself is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(agent_rocketride): release the timed-out call from a named function

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

@dk-rocketride dk-rocketride left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changed lines as #2715, which has been on stage since 10-20. Merging so today's develop-to-stage cut keeps the fix.

@dk-rocketride
dk-rocketride merged commit 40ea9ec into rocketride-org:develop Oct 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:nodes Python pipeline nodes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent_rocketride: the wait for a timed-out tool call is logged as an error, so a run that answered looks failed

2 participants