Repository navigation
fix(ci): cancel superseded builds; don't drop module labels on script changes - #2378
Conversation
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: rocketride-org/rocketride-server/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR updates module label matching to exclude documentation paths and changes three CI job guards to skip execution after workflow cancellation. ChangesModule Label Matching
CI Cancellation Guards
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kwit75
left a comment
There was a problem hiding this comment.
Both fixes are right, and the always() one explains something I hit on Friday.
always() runs a job even when the workflow is cancelled, so cancel-in-progress never actually stopped anything — superseded builds kept burning runners to completion. I saw exactly that in the prerelease history: three runs on Friday evening, two cancelled and one failed, all overlapping. !cancelled() keeps the "run even if a dependency failed" behaviour and drops the part that defeats concurrency.
Checked the three you left alone and they are the right three: Trivy SARIF upload, ci-ok, and the Discord notify all legitimately need to run after a failure.
Also checked the interaction that worried me — if builds now get cancelled rather than running to completion, does ci-ok still catch it? It does: contains(needs.*.result, 'cancelled') is already in the condition and exits 1. No hole.
On the labeler: the old all-globs-to-all-files: "!**/scripts/**" required every changed file to be outside scripts/, so one script edit stripped the module labels off the whole PR. all-globs-to-any-file per module with the negations inline is the correct shape.
Not in the release — this targets develop, and stage is frozen pending a scope decision.
… changes (rocketride-org#2378) * fix(ci): cancel * fix(ci): labeler
Superseded CI builds didn't cancel:
build,build-skipandshell-contractusedalways(), which ignores cancellation. They now use!cancelled().Module labels were dropped whenever a PR touched any
scripts/file. A module label is now added if at least one changed file is outsidescripts/anddocs/.🤖 Generated with Claude Code
Summary by CodeRabbit