Skip to content

fix(ci): cancel superseded builds; don't drop module labels on script changes - #2378

Merged
stepmikhaylov merged 2 commits into
developfrom
fix/ci-cancel
Sep 21, 2026
Merged

stepmikhaylov merged 2 commits into
developfrom
fix/ci-cancel

Conversation

@stepmikhaylov

@stepmikhaylov stepmikhaylov commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Superseded CI builds didn't cancel: build, build-skip and shell-contract used always(), which ignores cancellation. They now use !cancelled().
Module labels were dropped whenever a PR touched any scripts/ file. A module label is now added if at least one changed file is outside scripts/ and docs/.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Improved automatic labeling so changes are categorized more accurately based on affected source areas.
    • Updated continuous integration behavior so selected checks stop running after a workflow is canceled, reducing unnecessary processing.

@github-actions github-actions Bot added the ci/cd CI/CD and build system label Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: rocketride-org/rocketride-server/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 65e73bf2-da48-462c-a3d9-72459fcbcb08

📥 Commits

Reviewing files that changed from the base of the PR and between 38d68be and abbcb20.

📒 Files selected for processing (2)
  • .github/labeler.yml
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates module label matching to exclude documentation paths and changes three CI job guards to skip execution after workflow cancellation.

Changes

Module Label Matching

Layer / File(s) Summary
Module label rule updates
.github/labeler.yml
Module labels use flat changed-files rules with all-globs-to-any-file. The rules exclude both **/scripts/** and **/docs/**.

CI Cancellation Guards

Layer / File(s) Summary
CI job cancellation guards
.github/workflows/ci.yml
The build, build-skip, and shell-contract jobs use !cancelled() && instead of always() &&.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both primary changes: cancelling superseded CI builds and preserving module labels when script changes occur.
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@stepmikhaylov
stepmikhaylov enabled auto-merge (squash) September 21, 2026 14:58

@kwit75 kwit75 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both fixes are right, and the always() one explains something I hit on Friday.

always() runs a job even when the workflow is cancelled, so cancel-in-progress never actually stopped anything — superseded builds kept burning runners to completion. I saw exactly that in the prerelease history: three runs on Friday evening, two cancelled and one failed, all overlapping. !cancelled() keeps the "run even if a dependency failed" behaviour and drops the part that defeats concurrency.

Checked the three you left alone and they are the right three: Trivy SARIF upload, ci-ok, and the Discord notify all legitimately need to run after a failure.

Also checked the interaction that worried me — if builds now get cancelled rather than running to completion, does ci-ok still catch it? It does: contains(needs.*.result, 'cancelled') is already in the condition and exits 1. No hole.

On the labeler: the old all-globs-to-all-files: "!**/scripts/**" required every changed file to be outside scripts/, so one script edit stripped the module labels off the whole PR. all-globs-to-any-file per module with the negations inline is the correct shape.

Not in the release — this targets develop, and stage is frozen pending a scope decision.

@stepmikhaylov
stepmikhaylov merged commit 6a99fb3 into develop Sep 21, 2026
38 of 41 checks passed
@stepmikhaylov
stepmikhaylov deleted the fix/ci-cancel branch September 21, 2026 16:19
AviNormie pushed a commit to AviNormie/rocketride-server that referenced this pull request Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd CI/CD and build system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants