Skip to content

fix(notion): accept search pagination cursors (#2338 to stage) - #2357

Merged
asclearuc merged 2 commits into
stagefrom
fix/stage-RR-2333-notion-search-cursor
Sep 18, 2026
Merged

asclearuc merged 2 commits into
stagefrom
fix/stage-RR-2333-notion-search-cursor

Conversation

@krishhgg

@krishhgg krishhgg commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Type

fix

Testing

  • Tests added or updated
  • Tested locally: 72 passed in nodes/test/tool_notion
  • Ruff check and format check pass
  • ./builder test passes — not run; focused node tests were used

Checklist

  • Commit messages follow conventional commits
  • No secrets or credentials included
  • Wiki updated (if applicable) — node README updated
  • Breaking changes documented (if applicable) — optional additive input; no breaking changes

Paired Pull Requests

Linked Issue

Fixes #2333

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • develop
  • release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3c304502-078d-4e9f-9db2-d5cc89f44ee0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@github-actions github-actions Bot added docs Documentation module:nodes Python pipeline nodes labels Sep 18, 2026

@asclearuc asclearuc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kgarg2468 — small and correct. start_cursor is forwarded only when truthy, which drops both '' and None, and that is byte-for-byte the pattern notion_query_database already uses in this same file, so the two pagination surfaces now behave identically. The parametrized test_omits_empty_start_cursor plus the schema test cover the input side, and the README tells callers to hold the other arguments steady across pages, which is the part agents get wrong.

This is the byte-identical port of #2338 onto stage (I compared the two diffs; they match exactly), so the review below is the same one I left on #2338.

Approve

No inline comments. CodeRabbit's Minor on quote style was correctly pushed back (Ruff Q003), and the Trivial on cursor coverage is addressed in 38902af9; both threads are resolved.

@asclearuc
asclearuc merged commit b7764b8 into stage Sep 18, 2026
24 of 25 checks passed
@asclearuc
asclearuc deleted the fix/stage-RR-2333-notion-search-cursor branch September 18, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation module:nodes Python pipeline nodes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants