Repository navigation
fix(notion): accept search pagination cursors (#2338 to stage) - #2357
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
asclearuc
left a comment
There was a problem hiding this comment.
Thanks @kgarg2468 — small and correct. start_cursor is forwarded only when truthy, which drops both '' and None, and that is byte-for-byte the pattern notion_query_database already uses in this same file, so the two pagination surfaces now behave identically. The parametrized test_omits_empty_start_cursor plus the schema test cover the input side, and the README tells callers to hold the other arguments steady across pages, which is the part agents get wrong.
This is the byte-identical port of #2338 onto stage (I compared the two diffs; they match exactly), so the review below is the same one I left on #2338.
Approve
No inline comments. CodeRabbit's Minor on quote style was correctly pushed back (Ruff Q003), and the Trivial on cursor coverage is addressed in 38902af9; both threads are resolved.
Summary
stagefor the current release.start_cursorin the Notion search tool schema.POST /searchand document how to continue fromnext_cursor.Type
fix
Testing
72 passedinnodes/test/tool_notion./builder testpasses — not run; focused node tests were usedChecklist
Paired Pull Requests
Linked Issue
Fixes #2333