Repository navigation
fix(rocket-ui): send a single-component validation as a one-item pipeline - #2344
dsapandora wants to merge 1 commit into
Conversation
…line
The node config panel validates one component on save and hands the host
`IComponentValidatePayload` — `{version, component}` (NodeConfigPanel.tsx). The
engine validates pipelines and requires `components`; without it every save
came back with "'pipeline.components' must be an array", whatever the node.
The host now sends that component as a one-item `components` list. A full
pipeline is untouched.
Reachable since #1573 fixed `rrext_validate`, which until then failed on every
call with "'pipeline' is missing or invalid" — so this payload never reached
the validator before.
Verified against the engine:
validatePipeline({'pipeline': {'version': 1, 'component': c}}) -> "'pipeline.components' must be an array"
validatePipeline({'pipeline': {'version': 1, 'components': [c]}}) -> 0 errors
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #2346 — same change against stage. |
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
Summary
IComponentValidatePayload—{version, component}(NodeConfigPanel.tsx:389).components, so every save came back withValidation error: 'pipeline.components' must be an array— with any node, in any pipeline.componentslist. A full pipeline goes through untouched.Why it appeared now
rrext_validatepassed the config to the engine without the envelope it requires, so every call failed with'pipeline' is missing or invalidregardless of the payload. #1573 fixed that on 8 Sep. This payload then reached the validator for the first time — and it does not carrycomponents.Reproduced
Against the engine, no client involved:
The first line is what the panel sends today; the second is what this PR sends.
Type
fix
Testing
./builder testpassesThe engine-side behaviour is pinned by the repro above.
tsc --noEmiton rocket-ui reports the same 109 pre-existing errors before and after (unbuilt workspace packages); none is in the changed function.Worth checking on review: the panel's error banner clears on a passing save, and a full-pipeline validation is unaffected.
Checklist
Note for a follow-up
packages/shell/src/types/project.ts:308documentsIComponentValidatePayloadas a shape "the validation endpoint accepts alongside a full pipeline". It does not, and has not. Either that comment is corrected or the server learns to accept it — worth deciding, separately from this fix.Linked Issue
Fixes #
🤖 Generated with Claude Code
https://claude.ai/code/session_01QDbS8z9t3zxErB6TMQeo9M