Skip to content

fix(rocket-ui): send a single-component validation as a one-item pipeline - #2344

Closed
dsapandora wants to merge 1 commit into
stagefrom
fix/validate-single-component-payload-stage
Closed

dsapandora wants to merge 1 commit into
stagefrom
fix/validate-single-component-payload-stage

Conversation

@dsapandora

@dsapandora dsapandora commented Sep 17, 2026 •

Copy link
Copy Markdown
Collaborator
Captura de pantalla 2026-09-18 a las 1 02 53 Same change as #2343 against `develop`, cherry-picked.

Summary

  • The node config panel validates one component on save and hands the host IComponentValidatePayload — {version, component} (NodeConfigPanel.tsx:389).
  • The engine validates pipelines and requires components, so every save came back with Validation error: 'pipeline.components' must be an array — with any node, in any pipeline.
  • The host now sends that single component as a one-item components list. A full pipeline goes through untouched.

Why it appeared now

rrext_validate passed the config to the engine without the envelope it requires, so every call failed with 'pipeline' is missing or invalid regardless of the payload. #1573 fixed that on 8 Sep. This payload then reached the validator for the first time — and it does not carry components.

Reproduced

Against the engine, no client involved:

from rocketlib import validatePipeline
c = {'id': 'llm_gemini_1', 'provider': 'llm_gemini', 'config': {}}

validatePipeline({'pipeline': {'version': 1, 'component': c}})      # errors=1
#   {'ccode': 40, 'message': "'pipeline.components' must be an array"}
validatePipeline({'pipeline': {'version': 1, 'components': [c]}})   # errors=0

The first line is what the panel sends today; the second is what this PR sends.

Type

fix

Testing

  • Tests added or updated
  • Tested locally
  • ./builder test passes

The engine-side behaviour is pinned by the repro above. tsc --noEmit on rocket-ui reports the same 109 pre-existing errors before and after (unbuilt workspace packages); none is in the changed function.

Worth checking on review: the panel's error banner clears on a passing save, and a full-pipeline validation is unaffected.

Checklist

  • Commit messages follow conventional commits
  • No secrets or credentials included
  • Wiki updated (if applicable)
  • Breaking changes documented (if applicable) — none

Note for a follow-up

packages/shell/src/types/project.ts:308 documents IComponentValidatePayload as a shape "the validation endpoint accepts alongside a full pipeline". It does not, and has not. Either that comment is corrected or the server learns to accept it — worth deciding, separately from this fix.

Linked Issue

Fixes #

🤖 Generated with Claude Code

https://claude.ai/code/session_01QDbS8z9t3zxErB6TMQeo9M

…line

The node config panel validates one component on save and hands the host
`IComponentValidatePayload` — `{version, component}` (NodeConfigPanel.tsx). The
engine validates pipelines and requires `components`; without it every save
came back with "'pipeline.components' must be an array", whatever the node.

The host now sends that component as a one-item `components` list. A full
pipeline is untouched.

Reachable since #1573 fixed `rrext_validate`, which until then failed on every
call with "'pipeline' is missing or invalid" — so this payload never reached
the validator before.

Verified against the engine:

    validatePipeline({'pipeline': {'version': 1, 'component': c}})    -> "'pipeline.components' must be an array"
    validatePipeline({'pipeline': {'version': 1, 'components': [c]}}) -> 0 errors
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • develop
  • release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: d7819bf6-c769-4c68-b9f5-08ebe5dd999d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dsapandora

Copy link
Copy Markdown
Collaborator Author

Superseded by #2346 — same change against stage.

@dsapandora dsapandora closed this Sep 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant