Repository navigation
fix(account): close DB broker HTTP errors - #2330
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughHTTP error handlers now close response bodies before raising errors, retrying, or continuing. The existing status codes and exception behavior remain in place. Tests verify closure across DB broker, Microsoft Graph, and OneDrive paths. ChangesHTTP error response cleanup
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to HTTP error responses are released on the covered broker, Microsoft Graph, and OneDrive paths without an evidenced behavior regression. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Out of Scope Changes checkExplanation The DB broker changes and their regression test implement Issue
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
🤖 Internal: Discord sync markerAuto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete. |
5f0272a to
75cc57a
Compare
asclearuc
left a comment
There was a problem hiding this comment.
Thanks @kgarg2468 — correct fix, and the test is the right one: asserting response_body.closed pins the actual resource behaviour instead of re-checking the error message. Capturing e.code before e.close() and keeping from e preserves the existing error contract exactly.
Approve
One non-blocking should fix is inline: four other HTTPError handlers in the repo drop the response the same way, and it may be worth deciding now whether to widen the fix or file a follow-up.
|
@coderabbitai review |
|
* fix(account): close DB broker HTTP errors Closes #2324 * fix(microsoft-365): close HTTP error responses --------- Co-authored-by: Krish Garg <kg@g14-node1.tailb99b1b.ts.net>
* fix(account): close DB broker HTTP errors Closes rocketride-org#2324 * fix(microsoft-365): close HTTP error responses --------- Co-authored-by: Krish Garg <kg@g14-node1.tailb99b1b.ts.net>
Summary
Type
fix
Testing
./builder test:fast lint:check surfaces:checknot run locally; GitHub CI is the final repository-wide gateChecklist
Agent context
OpenAI Codex (gpt-5.6-sol) / T3 Code, autonomous under explicit approval. Focused tests and develop/stage patch parity were verified locally; engine-dependent builder suites remain delegated to GitHub CI.
Paired PR
Stage: #2366
Linked Issue
Fixes #2324