Skip to content

fix(shared-ui): keep a finished run's diagnostics visible in the Errors pane - #1833

Open
Aryan-070 wants to merge 1 commit into
rocketride-org:developfrom
Aryan-070:fix/RR-1832-diagnostics-survive-run-end
Open

Aryan-070 wants to merge 1 commit into
rocketride-org:developfrom
Aryan-070:fix/RR-1832-diagnostics-survive-run-end

Conversation

@Aryan-070

@Aryan-070 Aryan-070 commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Errors and Warnings now fall back to the task's own status outside a live track, so a finished run's diagnostics stay readable instead of vanishing the moment it ends.
  • Updates the empty-state copy, which currently documents the behaviour being fixed.

Type

fix

errorItems and warningItems were gated on cleared, which is !track.active. active is not "a run exists" — useTaskEvents.ts:646:

return { chapter, active: chapter.endTime == null || position < chapter.endTime };

It means "the position sits inside a chapter that has not ended". So as soon as a run finished and endTime was set, cleared went true and both arrays were emptied one line before render:

const errorItems   = cleared ? [] : (paneStatus?.errors ?? []);   // :534
const warningItems = cleared ? [] : (paneStatus?.warnings ?? []); // :535

The pane then displayed "No errors or warnings" about arrays it had just discarded. A run that failed thirty seconds ago reported having raised nothing.

The strongest evidence that this is a mismatch rather than a deliberate choice is the pane's own empty-state text:

Problems raised by the pipeline appear here while it runs or when replaying a recorded run.

That is a correct description of a streaming accumulating window, and the wrong description for a status snapshot — which is what Errors and Warnings are. Updated in this PR to match the fixed behaviour.

Diagnostics raised when a node is configured rather than run have no chapter at all, so the same gate discarded them permanently. That case follows from the same mechanism.

Scope is deliberately narrow: gating on cleared is correct for the accumulating panes and they are left alone — tokens (:562) and StatusPane (:629) still use it. Replay still blanks, because there the question genuinely is "what was true at this position".

Testing

  • Tests added or updated
  • Tested locally
  • ./builder test passes
tsc --noEmit -p packages/shared-ui/tsconfig.json     0 errors
node --import tsx --test scripts/*.test.mjs          28 passed

No test added, and I want to be straight about why rather than let the unchecked box pass silently: SourcePanel is a 700-line component whose state comes from useTaskEvents, a live event-stream hook. Asserting this behaviour properly means driving that hook through a run's full lifecycle — open chapter, events, endTime set — and there is no existing harness for it (packages/shared-ui's suite is scripts/*.test.mjs plus a handful of *.test.tsx, none of which mount this component). Building one is a larger piece of work than the three-line fix and I did not want to bundle it in. If you would like it, I am happy to do it as a follow-up — say the word.

Also worth stating plainly: this was traced by reading the source, not by instrumenting a live session. The completed-run case follows directly from active's definition and I am confident in it; the configure-time case is inferred from the same mechanism rather than separately observed.

Checklist

  • Commit messages follow conventional commits
  • No secrets or credentials included
  • Wiki updated (if applicable)
  • Breaking changes documented (if applicable)

Separate finding, deliberately not fixed here — ProjectView.tsx:570 passes liveTaskStatus={runKind === 'dev' ? statusMap[src.id] : undefined}, so the DEPLOY tab has no live status at all regardless of this gate. It is a different cause and belongs in its own change (and #1782 is already touching that file). Flagging it because it will look like this bug when tested.

Linked Issue

Fixes #1832

Summary by CodeRabbit

  • Bug Fixes
    • Error and warning panes now keep showing live task status after a run finishes.
    • Replay mode continues to behave as position-specific.
    • Updated the empty-state message to make it clear that issues remain visible after completion.

…rs pane

errorItems and warningItems were gated on `cleared`, which is
`!track.active` -- and `active` means "inside a chapter that has not ended"
(useTaskEvents.ts:646), not "a run exists". So the moment a run finished and
endTime was set, both lists were emptied one line before render and the pane
displayed "No errors or warnings" about arrays it had just discarded. A run
that failed thirty seconds ago reported having raised nothing.

The pane's own empty-state copy stated the assumption -- "appear here while
it runs or when replaying a recorded run" -- which is a correct description
for a streaming window and wrong for a status snapshot. Updated with the fix.

Diagnostics raised when a node is configured rather than run have no chapter
at all, so the same gate discarded them permanently.

Outside a track the panes now fall back to the task's own status. Replay
still blanks, because there the question genuinely is "what was true at this
position". The accumulating panes (tokens, StatusPane) stay on `cleared`,
where that gate is correct.

Refs rocketride-org#1832
@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a12c1667-b616-4de8-83d4-2baa060d88c3

📥 Commits

Reviewing files that changed from the base of the PR and between 243c1f2 and 19bde7e.

📒 Files selected for processing (1)
  • packages/shared-ui/src/modules/project/components/SourcePanel.tsx

📝 Walkthrough

Walkthrough

SourcePanel now preserves errors and warnings from completed runs by using live task status outside replay mode. Replay remains position-scoped. The empty-state text now reflects completed-run diagnostics.

Changes

Diagnostics retention

Layer / File(s) Summary
Snapshot diagnostics and empty state
packages/shared-ui/src/modules/project/components/SourcePanel.tsx
Errors and warnings now use live task status when the track is inactive, except during replay. The empty-state description includes completed-run problems.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jmaionchi, stepmikhaylov, rod-christensen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: keeping completed-run diagnostics visible in the Errors pane.
Linked Issues check ✅ Passed The changes satisfy issue #1832 by retaining completed-run diagnostics, supporting outside-chapter status, and preserving replay behavior.
Out of Scope Changes check ✅ Passed All changes are limited to the requested diagnostic fallback and related empty-state text in SourcePanel.tsx.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the module:ui Chat UI and Dropper UI label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
🤖 Internal: Discord sync marker

Auto-managed by the Discord notification workflow. Stores the linked Discord message ID and forum thread ID. Do not edit or delete.

@Aryan-070

Copy link
Copy Markdown
Contributor Author

The Build / macOS (ARM64) failure here is in the Set up vcpkg step, which runs before any of this PR's code is compiled — so it is not caused by the change. This PR touches one TypeScript file (13 lines in SourcePanel.tsx); nothing in it reaches vcpkg or the C++ build.

For comparison, macOS (ARM64) is green on the other PRs I have open right now, including larger ones: #1815, #1819, #1821, #1823, #1825, #1827.

Locally: tsc --noEmit -p packages/shared-ui/tsconfig.json reports 0 errors and shared-ui's test suite passes.

I do not have rerun rights on this repo — could someone re-run the failed job when convenient? Happy to push an empty commit instead if you would rather, though that would dismiss any review already in flight.

@Aryan-070

Copy link
Copy Markdown
Contributor Author

Following up on my earlier comment with the actual cause, now that the run's logs are available — it is a runner network failure, not the change.

The macOS (ARM64) runner lost connectivity to the npm registry during dependency install:

05:56:29  WARN  GET https://registry.npmjs.org/node-addon-api/-/node-addon-api-7.1.1.tgz
                error (ERR_SOCKET_TIMEOUT). Will retry in 10 seconds. 2 retries left.
          ... same for @eslint/js, prebuild-install, detect-libc, expand-template,
              github-from-package, minimist, mkdirp-classic, napi-build-utils,
              node-abi, semver, pump, end-of-stream, once, wrappy, rc

05:57:09  WARN  GET https://registry.npmjs.org/node-addon-api/-/node-addon-api-7.1.1.tgz
                error (ENOTFOUND). Will retry in 1 minute. 1 retries left.

Sixteen packages, ERR_SOCKET_TIMEOUT escalating to ENOTFOUND (DNS), all retries exhausted. CI OK then fails downstream simply because it aggregates that job.

This PR changes one TypeScript file — 13 lines in packages/shared-ui/src/modules/project/components/SourcePanel.tsx. Nothing in it reaches npm resolution, vcpkg, or the C++ build, and the same job is green on my other open PRs (#1813, #1815, #1819, #1821, #1823, #1825, #1827, #1830).

A re-run should clear it. I do not have rerun rights here — happy to push an empty commit instead if you would prefer, though that would dismiss any review in flight.

@Aryan-070

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nihalnihalani

Copy link
Copy Markdown
Collaborator

Still worth doing, and the diagnosis holds on today's develop: SourcePanel.tsx:535-536 are still cleared ? [] : (paneStatus?.errors ?? []) with const cleared = !track.active at line 384, so a finished run still empties both arrays one line before the "No errors or warnings" empty state at 592 renders.

The blocker is that the file moved. #1843 (488d076, 2026-08-07) replaced packages/shared-ui with apps/shared, so this needs rebasing onto apps/shared/src/modules/project/components/SourcePanel.tsx - same content, new path. That will also get you a fresh CI run; your registry-timeout read of the macOS red looks right. One thing to expect from a rebase: develop's own Shell API contract job is failing right now on an unrelated credentials-catalog gap (text_output.password has no entry in packages/ai/src/ai/modules/mcp/credentials.json), which open #2192 fixes. That red is not yours.

@thegoodengineer

Copy link
Copy Markdown

Review: #1833 fix(shared-ui): keep a finished run's diagnostics visible in the Errors pane

Verdict: request changes, but only because the branch no longer merges and CI is red and stale. The reasoning and the three-line fix hold up under everything I threw at them, and the bug is still live on develop today. Rebase, and this is close to ready.

Metrics

Metric Value Method
Change size source 1 file, +13/-3. No test, doc, config, or generated changes. Of the 13 added lines, 9 are comment. gh pr view --json files,additions,deletions and reading the diff
New surface 1 new local const (snapshotStatus). No new exports, files, or dependencies. read the diff
Test suite not measured. The worktree has no node_modules and the repo installs with pnpm across the whole workspace, which I did not run. The PR reports tsc --noEmit clean and 28 passing scripts/*.test.mjs. I could not verify either. attempted, see reason
Diff coverage not measured. No coverage tooling was run, and the PR adds no test, so diff coverage on the changed lines is 0 either way. see untested-surface finding below
CI 14 pass, 2 fail (Build / macOS (ARM64), CI OK), 4 skipped. The run is from head 19bde7ec and its logs have expired (HTTP 410), so the failure cannot be attributed. gh pr checks 1833, gh run view --log-failed
Mergeability CONFLICTING / DIRTY gh pr view --json mergeable,mergeStateStatus
Branch freshness 182 commits behind develop. Merge base 243c1f26. git rev-list --count, git merge-base

Invariants checked

Derived from AGENTS.md, CODEOWNERS, the CI workflows, and the code itself.

  • TS conventions (tabs, single quotes, semicolons): passed
  • Doc rule from AGENTS.md: not applicable. No public contract changed, so no co-located doc update is required. The user-visible string change lives in the component itself.
  • VS Code extension rules (Callout.call, AppError, logger.*): not applicable. The change is in shared UI, not apps/vscode.
  • Secrets: passed
  • Public contract: passed. snapshotStatus is local, no prop or exported type changed.
  • Data safety: not applicable. Read-only render path.
  • Security boundaries: not applicable.
  • Verification: passed. No test, lint rule, or check was removed or weakened.
  • Layering: passed. The fix uses props and state the component already holds, and adds no import.
  • Scope discipline: passed. The accumulating panes still gate on cleared (tokens at :563, StatusPane at :630, flowStatus at :523), which matches what the PR says it left alone.

Findings

[medium] The branch no longer merges: the file moved out from under it
Location: packages/shared-ui/src/modules/project/components/SourcePanel.tsx (PR path)
Claim: SourcePanel.tsx was deleted from packages/shared-ui/ and now lives at apps/shared/src/modules/project/components/SourcePanel.tsx. GitHub reports the PR as CONFLICTING / DIRTY.
Evidence: git log --diff-filter=D origin/develop names commit 488d076b feat(platform): frozen-shell platform as the deletion. With rename detection off, the merge is an explicit conflict:

CONFLICT (modify/delete): packages/shared-ui/src/modules/project/components/SourcePanel.tsx
deleted in origin/develop and modified in refs/pr-review/1833

Refutation attempted: I first checked whether git could resolve it by rename detection, and with detection on git merge-tree does produce a clean tree that lands the fix at the new path. So this is not unresolvable. But GitHub's own mergeability check disagrees and says CONFLICTING, and that is what gates the merge button, so the conflict is real in practice.
Suggested direction: rebase onto develop and move the change to apps/shared/src/modules/project/components/SourcePanel.tsx. It should be close to mechanical. I diffed the relocated file against this PR's base copy: the only differences are import paths (local relative paths became imports from shell). The target lines are unchanged and still carry the bug:

apps/shared/src/modules/project/components/SourcePanel.tsx:534
        const errorItems = cleared ? [] : (paneStatus?.errors ?? []);
        const warningItems = cleared ? [] : (paneStatus?.warnings ?? []);

and the old empty-state copy is still at :591. So the fix is still needed and still applies.

[medium] Last CI run is red, and its logs are gone
Location: not a code location
Claim: Build / macOS (ARM64) and CI OK failed on the current head. I cannot tell whether the failure relates to this change.
Evidence: gh pr checks 1833 shows both red. gh run view --job 92221013626 --log-failed returns HTTP 410 because the run's logs have been expired by retention. Build / Ubuntu 22.04 and Build / Windows Server 2022 both passed on the same run, which makes a macOS-specific or infrastructure cause more likely than this diff, since the diff is one .tsx file.
Refutation attempted: I looked for a mechanism by which a 3-line change in a React component could break only the macOS build and not Ubuntu or Windows. I could not construct one. That is an argument for the failure being unrelated, not proof of it.
Suggested direction: the rebase will trigger a fresh run and settle this. It needs to be green before merge regardless.

[low] The new empty-state copy is wrong on the DEPLOY tab
Location: packages/shared-ui/src/modules/project/components/SourcePanel.tsx:602
Claim: The copy now promises that problems appear "after it finishes", but on the DEPLOY tab the fallback has nothing to fall back to, so the pane still goes blank when a deploy run ends. The copy change is global while the fix is effectively dev-only.
Evidence: the fallback reads liveTaskStatus, and ProjectView.tsx:570 passes liveTaskStatus={runKind === 'dev' ? statusMap[src.id] : undefined}. On the DEPLOY tab it is always undefined, so snapshotStatus is undefined and both lists stay empty. This is still true on develop (apps/shared/src/modules/project/ProjectView.tsx:628), so the rebase will not change it.
Refutation attempted: The PR body flags this same ProjectView line as a separate pre-existing issue, and I agree that fixing it belongs in its own change. But that argument covers the code, not the copy: before this PR the text said "while it runs or when replaying", which was accurate on both tabs. After it, the text is accurate on DEV and inaccurate on DEPLOY. So the copy change does introduce a small new mismatch rather than inheriting one.
Suggested direction: no strong opinion. Either leave the old copy until the deploy path is fixed, or keep the new copy and note the deploy gap in the linked issue so the two land together.

[low] The fix does not survive a reconnect
Location: apps/vscode/src/providers/views/Project/ProjectWebview.tsx:265-268
Claim: Both hosts empty the status map on reconnect. Since a finished run emits no further status events, liveTaskStatus goes undefined and stays that way, so the restored diagnostics vanish again on the next reconnect. That is the same symptom the PR fixes, in a narrower window.
Evidence: in the VS Code host, the shell:connectionChange case runs setStatusMap({}) and setLiveLogEvents([]) when msg.isConnected. The same pattern is in apps/rocket-ui/src/providers/ProjectProvider.tsx:289-293 on develop. With the map empty and no live run to repopulate it, snapshotStatus resolves to undefined and both lists render empty under the new copy that promises otherwise.
Refutation attempted: I checked whether something re-seeds the map after a reconnect. ProjectWebview.tsx:162 does seed from msg.statuses on project:init, so a fresh view load recovers whatever the extension host holds. But the reconnect path at :267 clears without re-seeding, and only a subsequent status event refills it. So the gap is real, though it needs a reconnect to hit and the pre-PR behavior in that state was equally blank. It is a shortfall in the fix's reach, not a regression.
Suggested direction: out of scope here. Worth noting on the linked issue so this does not later get filed as the fix not working.

[low] No test covers the fixed behavior
Location: packages/shared-ui/src/modules/project/components/SourcePanel.tsx:544
Claim: Nothing fails if the gate is reintroduced.
Evidence: no test file in packages/shared-ui mounts SourcePanel, and the PR adds none.
Refutation attempted: I weighed the PR's stated reason, which is that asserting this means driving useTaskEvents through a full run lifecycle with no existing harness. Having read the hook, I think that is a fair assessment rather than an excuse: resolveTrack depends on a timeline cache, a fold buffer, and cursor position, and standing that up is a larger piece of work than the fix. I also considered whether a cheaper test exists, and the honest answer is that the interesting logic is one ternary over three props, so a focused test would mostly restate it.
Suggested direction: low priority. If a harness ever lands for this hook, this is a good first case for it.

Refutation log

  1. Can the fallback show data from the wrong run? This was my main concern: if a user scrubbed the DVR into a dead zone between two old runs, showing the current live status would be wrong. It cannot happen. useTaskEvents.ts:369 defines const mode: PlayerMode = pinned ? 'live' : 'replay', so any position off the live edge is already replay, and the fix returns undefined there. cleared && !isReplay therefore means exactly "pinned to the live edge with no open chapter", where the latest status is the correct thing to show. The change holds up.
  2. Does liveTaskStatus still hold the errors once the run ends? If the host dropped the status on completion, the fix would be a no-op. It does not. ProjectWebview.tsx:212 merges each update with setStatusMap((prev) => ({ ...prev, [source]: status })), keyed by source, and nothing clears it on task completion. The final snapshot of a finished run stays, which is exactly what the fallback needs. The change holds up for the case it targets. The one state that does drop it is reconnect, which is the low finding above.
  3. Is the diagnosis of active accurate, or is the PR quoting a line out of context? I read resolveTrack in full. It returns active: chapter.endTime == null || position < chapter.endTime, and trackEvents returns { chapter: null, active: false, events: [] } when there is no position or no resolved chapter. So cleared really does go true the moment endTime is set. The change holds up.
  4. Does it regress the live-run case? No. When the track is active, snapshotStatus is paneStatus, which is what the old code used. Identical behavior. The change holds up.
  5. Does it regress replay? No. In replay with an active track it is paneStatus; in replay outside a track it is undefined, which produces the same empty lists as the old cleared ? []. The change holds up.
  6. Does it leak into the accumulating panes? No. Only errorItems and warningItems were rewired. Tokens, StatusPane, and the flowStatus memo still read cleared. The change holds up.
  7. Types. snapshotStatus is TaskStatus | undefined, and TaskStatus declares errors: string[] and warnings: string[] (apps/vscode/src/shared/types/taskStatus.ts:147-150), which matches Errors' items: string[] (Errors.tsx:117). No new optional-access risk: both reads are already guarded by ?. and ?? []. The change holds up.
  8. Scope creep. The diff is exactly the ternary, the comment, and the copy. Nothing else. The change holds up.
  9. One claim I could not verify: the PR says configure-time diagnostics (raised with no chapter at all) are also restored by this change. That path is reachable in principle, since no chapter means cleared is true, but confirming it needs a live session and the PR says it was inferred rather than observed. I am not counting it against the change, just noting it is unverified.

I did not attach a screenshot: reproducing this needs the VS Code extension running against a live engine with a failing pipeline, which I could not drive here. The behavior is established from the source path above instead.

Review ran in an isolated worktree at commit 19bde7ec81acf8d572bdc2c2330f903e4a115bd8.

@jmaionchi @Rod-Christensen @stepmikhaylov the fix itself looks right to me and the bug is still present on develop at apps/shared/src/modules/project/components/SourcePanel.tsx:534. It just needs a rebase onto the moved file and a green CI run.

@joshuadarron joshuadarron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes

The PR stops the Errors pane from emptying when a run ends: outside a live track, it falls back to the task's live status instead of []. The bug is real and still present on develop. The PR can't merge as it stands: the file has moved, CI is failing, and the fix pulls from a second status source and has no test.

Blocking

  • Merge conflicts with the base branch. Rebase or merge the base branch and resolve them.
  • CI checks failing: Build / macOS (ARM64), CI OK
  • UI files changed with no screenshots in the PR body. Add before and after screenshots. Files:
    • packages/shared-ui/src/modules/project/components/SourcePanel.tsx
  • SourcePanel.tsx no longer exists at this path on develop. #1843 moved it to apps/shared/src/modules/project/components/SourcePanel.tsx, and the bug is still there at :534. Rebase and apply the fix to the new path.
  • SourcePanel.tsx:544 Replace the nested ternary with if blocks (code-taste: readability). Better still, extract the selection into a small exported pure function, for example selectDiagnosticsStatus({ isCleared, isReplay, paneStatus }).
  • SourcePanel.tsx:544 Use paneStatus here, not liveTaskStatus. The block comment at :370-376 says the snapshot panes read from the stream in both modes so that they have "one source of truth", and that the host's live map belongs to the header only. streamStatus is already the last snapshot at-or-before the position, so if (isCleared && isReplay) → undefined, else paneStatus keeps one source and fixes the bug. If you think liveTaskStatus is needed (for example for configure-time diagnostics that never reach the stream), explain why in the PR and update that comment.
  • SourcePanel.tsx:365-385 The DEAD ZONE comments ("pane data renders only when the position sits INSIDE a running track", "the snapshot panes gate on the same fact") become false with this change. Update them in the same PR. They also list tokens and flow as snapshot panes, which contradicts the PR body's claim that tokens is an accumulating pane. In the comment, say why errors leave the gate while tokens (:563) and flow (:523) keep it.
  • There's no test for the new logic. Once the selection is a pure function (see above), you don't need a harness for the hook. Add a unit test covering three cases: inside a track, a live dead zone (status is kept), and a replay dead zone (blank).

Should fix

  • SourcePanel.tsx:535-543 Cut the comment to the why, in two or three lines. Drop the narrative of the old bug and the useTaskEvents.ts:646 line reference, which will go stale. The history belongs in the commit message.

// status. Replay still blanks, because there the question genuinely is "what
// was true at this position". The accumulating panes below stay on `cleared`,
// where that gate is correct.
const snapshotStatus = cleared ? (isReplay ? undefined : liveTaskStatus) : paneStatus;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blocking] Replace the nested ternary with if blocks (code-taste: readability), ideally inside an exported pure helper that you can unit-test. Also read from paneStatus here, not liveTaskStatus. The comment at :370-376 keeps the snapshot panes on the stream as the single source of truth, and streamStatus already holds the last snapshot at-or-before the position. Blank only when isCleared && isReplay; otherwise use paneStatus.

Comment on lines +535 to +543
// Errors/Warnings are a SNAPSHOT of the task's problems, not an accumulating
// window, so they must not vanish the moment a run ends. `cleared` is
// `!track.active`, and `active` means "inside a chapter that has not ended"
// (useTaskEvents.ts:646) — so gating these on it emptied both lists as soon
// as endTime was set, and the pane reported "No errors or warnings" about
// arrays it had just discarded. Outside a track, fall back to the task's own
// status. Replay still blanks, because there the question genuinely is "what
// was true at this position". The accumulating panes below stay on `cleared`,
// where that gate is correct.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[should fix] Cut this to the why, in two or three lines: errors/warnings are a status snapshot, so outside a live track they keep the latest one, and replay still blanks. Drop the bug narrative and the useTaskEvents.ts:646 reference, which will go stale. [blocking, related] Update the DEAD ZONE comments at :365-385, which still say every snapshot pane clears outside a track.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ui Chat UI and Dropper UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(shared-ui): Errors and Warnings panes discard a completed run's diagnostics before rendering

4 participants