Skip to content

Add executor init arg to MetricsService - #94

Closed
hateyouinfinity wants to merge 1 commit into
robusta-dev:mainfrom
hateyouinfinity:executors
Closed

hateyouinfinity wants to merge 1 commit into
robusta-dev:mainfrom
hateyouinfinity:executors

Conversation

@hateyouinfinity

Copy link
Copy Markdown

Fixes a bug likely introduced in #82.
MetricsLoader.get_metrics_service passes executor to VictoriaMetricsService and ThanosMetricsService, but those classes don't have a corresponding init arg, so an exception is always thrown if loop reaches them.

@CLAassistant

CLAassistant commented Jul 3, 2023 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Avi-Robusta

Copy link
Copy Markdown
Contributor

hey, good catch, we already merged a fix the other day but thank you for opening the PR

@Avi-Robusta Avi-Robusta closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants