Skip to content

feat: add selector for victoriametrics running in cluster mode - #530

Merged
aantn merged 1 commit into
robusta-dev:mainfrom
NorddeutscherRundfunk:vm-selectors
Jun 8, 2026
Merged

aantn merged 1 commit into
robusta-dev:mainfrom
NorddeutscherRundfunk:vm-selectors

Conversation

@muffl0n

@muffl0n muffl0n commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Add selector "app.kubernetes.io/component=vmselect" to find service victoria-metrics-cluster-vmselect deployed by https://artifacthub.io/packages/helm/victoriametrics/victoria-metrics-cluster

Add selector "app.kubernetes.io/component=vmselect" to find service victoria-metrics-cluster-vmselect deployed by https://artifacthub.io/packages/helm/victoriametrics/victoria-metrics-cluster
@CLAassistant

CLAassistant commented Jun 8, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e74c97d2-2c51-413f-9639-436347cd0cf0

📥 Commits

Reviewing files that changed from the base of the PR and between d7b7c7d and 3c0e915.

📒 Files selected for processing (1)
  • robusta_krr/core/integrations/prometheus/metrics_service/victoria_metrics_service.py

Walkthrough

This PR extends Victoria Metrics service discovery to include an additional Kubernetes label selector (app.kubernetes.io/component=vmselect) in the fallback discovery mechanism. This allows the metrics service to locate Victoria Metrics instances by the vmselect component label when other discovery methods are exhausted.

Changes

Victoria Metrics Selector Expansion

Layer / File(s) Summary
Victoria Metrics vmselect selector expansion
robusta_krr/core/integrations/prometheus/metrics_service/victoria_metrics_service.py
Added app.kubernetes.io/component=vmselect to the fallback Kubernetes selectors used when discovering Victoria Metrics service endpoints, improving service location reliability in environments with vmselect deployments.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a selector for VictoriaMetrics running in cluster mode, which matches the file modification to add the vmselect component selector.
Description check ✅ Passed The description is directly related to the changeset, specifying the exact selector being added and referencing the VictoriaMetrics Helm chart it targets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aantn
aantn merged commit 383275a into robusta-dev:main Jun 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants