Skip to content

Add Makefile for developer workflow#1

Open
jaeyeom wants to merge 2 commits intomainfrom
add-makefile
Open

Add Makefile for developer workflow#1
jaeyeom wants to merge 2 commits intomainfrom
add-makefile

Conversation

@jaeyeom
Copy link
Copy Markdown

@jaeyeom jaeyeom commented Apr 6, 2026

Summary

  • Adds a Makefile wrapping existing npm scripts for consistent make usage locally and in CI
  • Targets: all, check, format, check-format, lint, fix, typecheck, test, test-unit, test-integration, test-e2e, test-all, build, clean, coverage
  • Parallel-safe: fix depends on format to prevent concurrent file writes; read-only targets are safe with make -j

Test plan

  • make -n all produces correct command sequence: format → fix → test → build
  • make -n check produces correct command sequence: check-format → lint → typecheck → test → build
  • Pre-commit hook passes (runs make -j check)

jaeyeom added 2 commits April 5, 2026 22:22
Wraps existing npm scripts with Make targets for consistent local and
CI usage. Includes format, lint, fix, typecheck, test, build, clean,
and coverage targets with parallel-safe dependency ordering.
fix already depends on format, so listing both caused format to run
twice. Now all: fix test build gets the same result in one pass.
@jaeyeom jaeyeom requested a review from serithemage April 6, 2026 07:15
@jaeyeom jaeyeom self-assigned this Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant