Account for coordinate schema changes in 054b451cc8#6
Closed
zrhoffman wants to merge 1 commit into
Closed
Conversation
Author
|
I know the source PR is closed, but you never know, maybe it will still be useful to have it fixed. |
rob05c
pushed a commit
that referenced
this pull request
May 20, 2020
* Topology Goose migrations - Create topology table - Create topology_cachegroup table - Create topology_cachegroup_parents table - Goose migration to add topology column to deliveryservice table * POST /topologies * Validation so far * Topologies endpoints for TO Python client * Topologies endpoint functions for Go client library * Create all nodes in a single query and all parents in a single query * adds toplogy views * adds ability to add cache groups to a top * adds fake origin layer * only allow org_loc to be at top of topology and moved some files around * adds the ability to see all servers assigned to a topology cg * GET /topologies * adds the ability to view servers for a cachgroup from the cg assignment view * adds the ability to select a 2nd parent cg * adds the ability to assign a second parent to nodes * some code cleanup * allows the selection of an item as well as determining whether a selection is required to submit the form * allows the selection of an item as well as determining whether a selection is required to submit the form * adds error message to node and cleanup * hooks up topology save in a fake way until api is ready * moves some more functionality into topologyutils * turning off create temporarily * makes a copy of the topology nodes to break references * added note to json section * removes uneccesary id and type from normalized topology * fixed but with root type * disables save button if topology has errors * fixes the select all button * fixes column widths in cg selection pane * adds the ability to create a topology * messing with some styles * changes top.desc to top.description and hooks up GET and POST topologies * adds MIT license info for angular-ui-tree component * moves tree css into own file * moves css back to correct spot * adds license info for angular-ui-tree css * moving fake stubs and halting non-implemented functionality * Fix merge conflicts * Bugfix: Order parents inside array_agg to support 2 parents * fixes bug where parent was not being set properly when only one valid parent (zrhoffman#2) * Abstract out adding nodes and adding parents into their own methods * performed some cleanup and added some comments (#3) * Bugfix: Return a propert HTTP status code from Read() * PUT /topologies?name={{name}} * Select query: Specify that we wants parents of a cachegroup in a specific topology, not just parents of a cachegroup * more cleanup (#4) * Bugfix: Rebind topology variable for a new topology * PUT /topologies?name={{name}} route * Bugfix: Do not mutate params when getting a cachegroup by name * hooks in topologies PUT (#5) * DELETE /topologies?name={{name}} * hooks topology delete up in TP (#6) * Make tc.Topology.Nodes a pointer * Check for cycles in the topology * Check for leaf mids * Validation improvements - Fix test for no nodes - Do not perform validation related to cachegroup types if all cachegroups were not found * Topologies API tests * Fix topologies API tests - Make the cyclical nodes topology have a cycle - Negate condition that asserts that checks if POSTing the invalid topology succeeded * Do not let a topology node be a parent of itself * Topologies docs * Add license headers * TO Changelog entry * adds expand on hover (zrhoffman#7) * PUT and DELETE should be auth.PrivLevelOperations * removes some uses of underscore.js (zrhoffman#8) * hides topologies menu item until feature is complete (zrhoffman#9) * Newer timestamps for Topologies goose migration * changes per PR review (zrhoffman#10) * minifies angular-ui-tree css * code simplification and cleanup per PR review * adds button types * safe way of invoking query params * removes debugging pane (zrhoffman#11) * Underline/overline just right * Use spaces for alignment * gofmt * fixes license issues (zrhoffman#12) * Return err, not nil * Return the result of api.ParseDBError() instead of binding it to userErr, sysErr, and errCode and then returning * Add function name and period * Simplify child/parent/rank uniqueness constraint * id column: serial -> bigserial * Add an extra newline before each sub-list * Add a period * Add a content type to the POST request * Add a content-type header to the PUT request * Add godocs * Capitalize Topology And link to the glossary * Remove tabs from migration * Revert "Simplify child/parent/rank uniqueness constraint" This reverts commit fbd99fa. * Move Topologies from API v2.0 to v3.0 * Updated docs API version * adds button type (zrhoffman#13) * upgrades TP from api v2 to v3 (zrhoffman#14) * reverts TP to v2 and introduces v3 for topologies (zrhoffman#15) * fixes bug where if you select all and then filter, the all selection would not filter. (zrhoffman#16) * Do not use pointers for topology nodes * Fix warnings * Group import with other TO imports * UpdateTopologyByID -> UpdateTopology * No need to load Parameters objects for Topologies tests * Swap comments * Make a struct for invalid topologies instead of twi separate slices * Make failed assertions fatal * - Test UpdateTopologies - Fix UpdateTopologies function definition * Fix mixed up variable names from resolving "Receiver names are different" warning in 36e0854 * Retrieve all cache groups for topology validation in a single query * Rename cachegroup type constants - EdgeCacheGroupType -> CacheGroupEdgeTypeName - MidCacheGroupType -> CacheGroupMidTypeName * Move parentCachegroup2 fixture to v3 API tests * Correct term: Topology -> Cache Group * gofmt * Defer closing DB connections * No need to delete nodes and parents when deleting an entire topology * Remove unnecessary blank argument * Use log.Close() to close responses * adds changelog entry and shows topologies menu item in TP (zrhoffman#17) Co-authored-by: Jeremy Mitchell <mitchell852@gmail.com> Co-authored-by: Jeremy Mitchell <mitchell852@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This pull request makes apache#2450 work again after the schema changes in 054b451 (migrations were updated in 41cc65a). Documentation is unaffected.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run API tests added in 66c3443.
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR