fix(rivetkit): sleep after run completion#4405
Merged
NathanFlurry merged 5 commits intomainfrom Mar 12, 2026
Merged
Conversation
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4405
|
🚅 Deployed to the rivet-pr-4405 environment in rivet-frontend
|
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4405
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4405
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4405
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change run handler semantics so actors only destroy when
c.destroy()is called explicitly. Finiterunhandlers, thrownrunerrors, completed workflows, and handled workflow failures now all leave the actor alive and sleeping when idle, while unhandled workflow-engine errors still surface asrunerrors.Type of change
How Has This Been Tested?
Added RivetKit driver-test coverage for run-handler exit/error sleep behavior and workflow completion/exhausted-step sleep behavior. Attempted targeted
pnpm --filter rivetkit test tests/driver-file-system.test.ts -t "run handler that exits early sleeps instead of destroying|run handler that throws error sleeps instead of destroying|completed workflows sleep instead of destroying the actor|failed workflow steps sleep instead of surfacing as run errors"afterpnpm install, but Vitest stopped before test collection because this checkout is missing generated workspace artifacts such asrivetkit-typescript/packages/workflow-engine/dist/schemas/v1.js.Checklist: