Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
🚅 Deployed to the rivet-pr-4341 environment in rivet-frontend
|
PR Review: fix: new project flow incorrect redirectSummary: This PR fixes a bug where project creation could succeed but navigation would silently fail (or navigate incorrectly), by using vars.organization from mutation variables instead of relying on route params. Navigation Fix (create-project-frame.tsx)The core change is correct and addresses a real bug. Before, the onSuccess handler had an early return when params.organization was missing. If the component was used outside a route that included organization in its params, the mutation would succeed but navigation would never happen (silent failure). It also relied on ambient route state rather than the data actually submitted. After, vars.organization is used, which always comes from the form submission. This makes the component self-contained and correct regardless of route context. Route File (orgs.$organization/new/index.tsx)The onSuccess signature update from (data) to (data, vars) is consistent with the updated component interface. Switching from params.organization to vars.organization is equivalent behavior (the form was initialized with params.organization) but more robust. UI Changes (actor-general.tsx)
Minor Observations
VerdictThe fix is correct, well-scoped, and addresses the root cause cleanly. No issues blocking merge. |
c87fdd6 to
5bf99ce
Compare
5bf99ce to
d754df4
Compare
c62aaa2 to
d754df4
Compare
Fixes RVT-6045
This pull request introduces several improvements and minor fixes across the frontend, focusing on better parameter handling in project creation navigation and small UI enhancements to the actor general information display.
Navigation and parameter handling improvements:
CreateProjectFrameContentcomponent to use theorganizationparameter from mutation variables (vars.organization) instead of relying on route parameters, ensuring more robust and consistent navigation after project creation. [1] [2] [3]onSuccesscallback in the organization project creation route to align with the new parameter handling, passingvars.organizationfor navigation instead of directly reading from route params.UI and styling enhancements:
ActorGeneralcomponent by adding minimum height styles to definition list elements and adjusting theDiscreteCopyButtonclasses for better alignment and appearance. [1] [2] [3] [4] [5] [6] [7]Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: