You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the hero headline and adds three new marketing sections (BenchmarksSection, CombineServicesSection, AIAppsSection) to the homepage.
Issues
Bug: Missing clipPath definition in RivetActorIcon
In CombineServicesSection.tsx, the custom SVG references clipPath="url(#_clip1)" (twice) but <clipPath id="_clip1"> is never defined anywhere in the SVG. This means the clipping has no effect and the icon may render incorrectly — some paths that should be masked will be visible.
// Two groups reference this, but it's never defined:<gclipPath="url(#_clip1)">
This looks like the SVG was exported from a design tool (e.g. Figma) and the clip definition was lost during cleanup. Verify the icon renders as intended and either add the missing <defs> block or remove the unused clipPath attributes.
Grammar: Parallel structure broken in hero headline
The updated headline reads:
AI needs to hold state, run for a long time, and realtime.
"realtime" is a noun/adjective here but the list uses verb phrases ("hold state", "run for a long time"). Consider:
AI needs to hold state, run for a long time, and respond in realtime.
Benchmark accuracy: "0ms added latency"
The claim 0ms added latency is physically impossible for any network-based system and may draw scrutiny. Consider a more defensible phrasing like ~0ms, <1ms, or anchoring it to a specific measurement (e.g., "in-process latency").
Minor Notes
PR title vs. scope
The commit type chore: update wording doesn't reflect the 341-line addition of three new React components. Consider feat(website): add benchmarks, combine-services, and AI apps sections (or similar) to better represent what was actually changed.
SVG animation approach mixing in CombineServicesSection
The animated dots use Framer Motion for opacity control but native SVG <animateMotion> for the path traversal, with fill="freeze" and no repeatCount. This fires once per in-view event. If the intent is a one-shot animation this is fine, but if you want it to loop you'll need repeatCount="indefinite" on the <animateMotion> element (and update the Framer Motion opacity animation to match). The hybrid approach is also harder to maintain — consider consolidating to Framer Motion's useMotionValue + MotionPath if looping behavior is added later.
Accessibility: SVG diagrams lack ARIA labels
The inline SVG diagrams in AIAppsSection are purely decorative but have no aria-hidden="true" attribute. Screen readers will attempt to read the raw text nodes ("AI", "actor", "actor", "actor") which is confusing. Add aria-hidden="true" to each diagram <svg>.
// Example fix in AIAppsSection card.diagram svgs:<svgviewBox="0 0 280 120"fill="none"className='h-auto w-full'aria-hidden="true">
The same applies to the connector SVGs in CombineServicesSection.
Looks Good
Section layout and animation patterns are consistent with the existing codebase style.
The useInView hook in CombineServicesSection with once: true is the right call for the path-drawing animation.
Mobile fallback in CombineServicesSection (simple down-arrow SVG) is a clean solution.
Component file structure follows the existing sections/ conventions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NathanFlurry
force-pushed
the
chore-udpate-wording
branch
from
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: