More consistent naming for sqlctemplate + docs#800
Merged
Conversation
A few more small follow ups for #794. I started renaming things late in the process while refactoring it, and a few of the renames didn't end up getting bubbled all the way through. Try to maintain roughly this vernacular: * **Template:** A template itself like `/* TEMPLATE: ...` along with its assigned template name. * **Replacement:** A replacement value for a template, possibly including some metadata like `Stable`. Get rid of the use of `tmpl` in favor of `replacement` for locals.
brandur
force-pushed
the
brandur-more-consistent-naming
branch
from
8759a01 to
b186d96
Compare
bgentry
approved these changes
Mar 9, 2025
Contributor
Author
|
Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few more small follow ups for #794. I started renaming things late in
the process while refactoring it, and a few of the renames didn't end up
getting bubbled all the way through.
Try to maintain roughly this vernacular:
Template: A template itself like
/* TEMPLATE: ...along with itsassigned template name.
Replacement: A replacement value for a template, possibly
including some metadata like
Stable.Get rid of the use of
tmplin favor ofreplacementfor locals.