Use sqlc.embed to embed a RiverJob row during unique insertion#464
Merged
Use sqlc.embed to embed a RiverJob row during unique insertion#464
sqlc.embed to embed a RiverJob row during unique insertion#464Conversation
Follows up #451 with a significant code quality improvement in which we can use `sqlc.embed` (which TIL about) to embed a `RiverJob` row directly on the returned struct, which means we can use our normal `jobRowFromInternal` to map it to a driver result instead of having to manually construct `RiverJob` property by property. Tipped off to the existence of `sqlc.embed` by @tadejsv [1]. Thank you! [1] #451 (comment)
bgentry
approved these changes
Jul 20, 2024
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
THE WHOLE TIME 🤦🏼♂️ glad to learn about this too.
Contributor
Author
Haha, I know right?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #451 with a significant code quality improvement in which we
can use
sqlc.embed(which TIL about) to embed aRiverJobrowdirectly on the returned struct, which means we can use our normal
jobRowFromInternalto map it to a driver result instead of having tomanually construct
RiverJobproperty by property.Tipped off to the existence of
sqlc.embedby @tadejsv [1]. Thank you![1] #451 (comment)